Bug 129009 - Add more new SPI methods
Summary: Add more new SPI methods
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
Depends on:
Reported: 2014-02-18 16:20 PST by Anders Carlsson
Modified: 2014-02-18 16:30 PST (History)
1 user (show)

See Also:

Patch (3.28 KB, patch)
2014-02-18 16:21 PST, Anders Carlsson
no flags Details | Formatted Diff | Diff
Patch (3.08 KB, patch)
2014-02-18 16:22 PST, Anders Carlsson
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-02-18 16:20:10 PST
Add more new SPI methods
Comment 1 Anders Carlsson 2014-02-18 16:21:46 PST
Created attachment 224563 [details]
Comment 2 Anders Carlsson 2014-02-18 16:22:25 PST
Created attachment 224564 [details]
Comment 3 WebKit Commit Bot 2014-02-18 16:25:12 PST
Attachment 224564 [details] did not pass style-queue:

ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:57:  Missing spaces around =  [whitespace/operators] [4]
Total errors found: 1 in 3 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Tim Horton 2014-02-18 16:25:22 PST
Comment on attachment 224564 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=224564&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:510
> +    return !applicationName ? nil : (NSString *)applicationName;

why not flip this? it reads better that way, imo. also, do you actually need this explicit cast?
Comment 5 Anders Carlsson 2014-02-18 16:30:56 PST
Committed r164330: <http://trac.webkit.org/changeset/164330>