WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 129000
[WebRTC] Updating RTCConfiguration to match WebRTC editor's draft of 01/27/2014
https://bugs.webkit.org/show_bug.cgi?id=129000
Summary
[WebRTC] Updating RTCConfiguration to match WebRTC editor's draft of 01/27/2014
Thiago de Barros Lacerda
Reported
2014-02-18 14:25:30 PST
Adding RTCIceTransports and RTCIdentityOption to RTCConfiguration object
Attachments
Patch
(14.50 KB, patch)
2014-02-18 14:39 PST
,
Thiago de Barros Lacerda
eric.carlson
: review+
thiago.lacerda
: commit-queue-
Details
Formatted Diff
Diff
Requested changes
(14.20 KB, patch)
2014-02-19 10:03 PST
,
Thiago de Barros Lacerda
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Thiago de Barros Lacerda
Comment 1
2014-02-18 14:39:54 PST
Created
attachment 224553
[details]
Patch
Eric Carlson
Comment 2
2014-02-18 16:10:14 PST
Comment on
attachment 224553
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=224553&action=review
> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:77 > + String iceTransports; > + String requestIdentity;
Nit: these can be declared just before they are used.
> Source/WebCore/platform/mediastream/RTCConfiguration.h:77 > + const String& iceTransports() { return m_iceTransports; }
Nit: this method can be made const.
> Source/WebCore/platform/mediastream/RTCConfiguration.h:83 > + const String& requestIdentity() { return m_requestIdentity; }
Ditto.
Thiago de Barros Lacerda
Comment 3
2014-02-19 10:03:06 PST
Created
attachment 224646
[details]
Requested changes
WebKit Commit Bot
Comment 4
2014-02-19 10:43:19 PST
Comment on
attachment 224646
[details]
Requested changes Clearing flags on attachment: 224646 Committed
r164372
: <
http://trac.webkit.org/changeset/164372
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug