RESOLVED FIXED 128995
Use std::swap() in HashTable::swap() 
https://bugs.webkit.org/show_bug.cgi?id=128995
Summary Use std::swap() in HashTable::swap()
Zan Dobersek
Reported 2014-02-18 14:04:55 PST
Use std::swap() in HashTable::swap()
Attachments
Patch (2.10 KB, patch)
2014-02-18 14:05 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2014-02-18 14:05:51 PST
Created attachment 224544 [details] Patch
Brent Fulgham
Comment 2 2014-02-19 11:19:55 PST
Comment on attachment 224544 [details] Patch It's nice to not reinvent the wheel! Thanks for catching this. Do we know if this gives any tiny microptimization based on the compiler being able to do moves instead of all of the copying? We probably don't measure enough to tell.
Zan Dobersek
Comment 3 2014-02-19 11:29:27 PST
Using Clang, Parser/HTML5-8266-ParseOnly.html runs about ~1% faster when using libc++ (not substantial, but measurable) and regresses slightly when using libstdc++. Haven't tested with GCC.
WebKit Commit Bot
Comment 4 2014-02-19 11:50:15 PST
Comment on attachment 224544 [details] Patch Clearing flags on attachment: 224544 Committed r164378: <http://trac.webkit.org/changeset/164378>
WebKit Commit Bot
Comment 5 2014-02-19 11:50:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.