Bug 128993 - Merge notifyComponentsOnChangedSelection into respondToSelectionChange
Summary: Merge notifyComponentsOnChangedSelection into respondToSelectionChange
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
Depends on:
Blocks: 127832
  Show dependency treegraph
Reported: 2014-02-18 13:47 PST by Ryosuke Niwa
Modified: 2014-02-18 14:33 PST (History)
4 users (show)

See Also:

Patch (4.70 KB, patch)
2014-02-18 13:53 PST, Ryosuke Niwa
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2014-02-18 13:47:10 PST
notifyComponentsOnChangedSelection was added in a very old WebKit merge in the downstream repository
when we added alternative text controller in WebKit to respondToSelectionChange.

The person who merged WebKit change probably didn't realize this but things in respondToSelectionChange
should really be moved into notifyComponentsOnChangedSelection and vice versa so simply merge them together.
Comment 1 Ryosuke Niwa 2014-02-18 13:53:31 PST
Created attachment 224543 [details]
Comment 2 Andreas Kling 2014-02-18 14:23:20 PST
Comment on attachment 224543 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=224543&action=review

Seems reasonable. r=me

> Source/WebCore/editing/Editor.cpp:3300
> +    // FIXME: Merge this to open source https://bugs.webkit.org/show_bug.cgi?id=38830

Is this comment actually relevant? We are *in* open source :)
Comment 3 Ryosuke Niwa 2014-02-18 14:33:24 PST
Committed r164320: <http://trac.webkit.org/changeset/164320>