Enable the Selector Compiler on Windows
Created attachment 224539 [details] Patch
This is 100% untested :) You need to enable the JS JIT, but not DFG nor FTL. Can one of you give this a shot?
The 64-bit Windows JIT is not enabled at the moment. This bug is on hold until that happens. :-(
(In reply to comment #3) > The 64-bit Windows JIT is not enabled at the moment. This bug is on hold until that happens. :-( Oh, not even the baseline JIT :(
I assume this is correct based on http://msdn.microsoft.com/en-us/library/6t169e9c.aspx I tested the css jit by applying https://bugs.webkit.org/show_bug.cgi?id=130638 and it *seemed* to work but I did not do rigorous enough testing to use enough registers for problems to arise. Is there a good way to test using a lot of registers in the css jit?
This patch needs to be updated to apply cleanly with the changes since February, but the registers are correct. Without this change, these tests crash: fast/selectors/case-insensitive-value-matching.html fast/selectors/querySelector-rightmost-child-chain-attribute-matching.html fast/selectors/querySelector-long-attribute-match-with-child-backtracking.html fast/selectors/querySelector-case-insensitive-attribute-match-with-svg.html fast/selectors/querySelector-long-multiple-attribute-match-with-child-backtracking.html fast/selectors/tree-modifying-case-insensitive-selectors.html fast/selectors/nth-child-with-backtracking.html fast/selectors/tree-modifying-selectors.html fast/selectors/querySelector-multiple-attribute-match-with-child-backtracking.html With this change all fast/selectors tests run without crashing.
Pull request: https://github.com/WebKit/WebKit/pull/19395
Committed 269638@main (ebfdd1c36b09): <https://commits.webkit.org/269638@main> Reviewed commits have been landed. Closing PR #19395 and removing active labels.
<rdar://problem/117329024>