Bug 128986 - AX: Searching for "immediate descendants only" can return unexpected results.
Summary: AX: Searching for "immediate descendants only" can return unexpected results.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac (Intel) OS X 10.9
: P2 Normal
Assignee: Samuel White
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-02-18 11:37 PST by Samuel White
Modified: 2014-02-18 14:34 PST (History)
14 users (show)

See Also:

Attachments
Patch. (5.59 KB, patch)
2014-02-18 11:50 PST, Samuel White 		no flags Details | Formatted Diff | Diff
Updated patch. (5.81 KB, patch)
2014-02-18 13:51 PST, Samuel White 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel White 2014-02-18 11:37:14 PST 
Distant descendant results are occasionally sneaking in. We are missing an application of the immediateDescendantsOnly flag during our DFS.
Comment 1 Radar WebKit Bug Importer 2014-02-18 11:37:52 PST 
<rdar://problem/16100054>
Comment 2 Radar WebKit Bug Importer 2014-02-18 11:37:53 PST 
<rdar://problem/16100055>
Comment 3 Samuel White 2014-02-18 11:38:53 PST 
We should also update the test to ensure fast search results match traditional children results (when appropriate).
Comment 4 Radar WebKit Bug Importer 2014-02-18 11:39:16 PST 
<rdar://problem/16100081>
Comment 5 Samuel White 2014-02-18 11:50:08 PST 
Created attachment 224529 [details]
Patch.
Comment 6 chris fleizach 2014-02-18 13:23:01 PST 
Comment on attachment 224529 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=224529&action=review

> Source/WebCore/ChangeLog:8
> +        Missed an application of the immediateDescendantsOnly during the initial implementation.

what was the application that was missed?
Comment 7 Samuel White 2014-02-18 13:51:59 PST 
Created attachment 224542 [details]
Updated patch.

Updated the commit message to better address your question. Marking for review as the previous patch passed without issue (only ChangeLog changes here). Thanks for looking Chris.
Comment 8 WebKit Commit Bot 2014-02-18 14:34:31 PST 
Comment on attachment 224542 [details]
Updated patch.

Clearing flags on attachment: 224542

Committed r164321: <http://trac.webkit.org/changeset/164321>
Comment 9 WebKit Commit Bot 2014-02-18 14:34:33 PST 
All reviewed patches have been landed.  Closing bug.