Bug 128974 – WebGL EXT_blend_minmax may now be implemented

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Florian Bösch]

The EXT_blend_minmax extension has been moved to draft and vendors are now encouraged to consider implementation.

Chrome ticket: https://code.google.com/p/chromium/issues/detail?id=344451
Firefox ticket: https://bugzilla.mozilla.org/show_bug.cgi?id=973815

[Florian Bösch]

The status of the EXT_blend_minmax extension has changed from draft to community approved.

[Roger Fong]

Done by chrome and firefox already.

[Roger Fong]

rdar://problem/19195535

[Roger Fong]

Created attachment 243211 [details]
patch

[Dean Jackson]

Comment on attachment 243211 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243211&action=review

> Source/WebCore/ChangeLog:11
> +        Tested by:
> +        webgl/1.0.3/conformance/extensions/ext-blend-minmax.html
> +        fast/canvas/webgl/constants.html

This is another one that is skipped by default. I think we should copy it in to fast/canvas/webgl or have a 1.0.3-ready directory with the non-skipped tests. What do you think?

> Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:18991
>      <ClInclude Include="..\html\canvas\EXTFragDepth.hâ />
> +    <ClInclude Include="..\html\canvas\EXTBlendMinMax.hâ />

Are these smart quotes or something?

[Roger Fong]

(In reply to comment #5)
> Comment on attachment 243211 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=243211&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        Tested by:
> > +        webgl/1.0.3/conformance/extensions/ext-blend-minmax.html
> > +        fast/canvas/webgl/constants.html
> 
> This is another one that is skipped by default. I think we should copy it in
> to fast/canvas/webgl or have a 1.0.3-ready directory with the non-skipped
> tests. What do you think?

So I actually unskipped that test on trunk but there are two different modes for the test. One where the extension is disabled and one when it's not.
So it was passing before because the extension wasn't enabled, and now it's still passing but running a different set of tests because it's enabled.

> 
> > Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:18991
> >      <ClInclude Include="..\html\canvas\EXTFragDepth.hâ />
> > +    <ClInclude Include="..\html\canvas\EXTBlendMinMax.hâ />
> 
> Are these smart quotes or something?

o.0 guess so, odd that the first ones aren't.

[Roger Fong]

> 
> So I actually unskipped that test on trunk but there are two different modes
> for the test. One where the extension is disabled and one when it's not.
> So it was passing before because the extension wasn't enabled, and now it's
> still passing but running a different set of tests because it's enabled.
> 

Maybe this means we need another test to test which extensions are enabled?

[Roger Fong]

http://trac.webkit.org/changeset/177235