Bug 128966 – Flex-box selection is not proper

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Layout and Rendering

[Sudarshan C P]

1.Fetch the attached page
2.place the cursor at the middle of any box
3.press ctr+A(Select all)

Current behavior:
Selection is not proper

Expected behavior:
selection should be proper

[Sudarshan C P]

Created attachment 224494 [details]
Test page

[Sudarshan C P]

Created attachment 224495 [details]
Mozilla behavior png

[Sudarshan C P]

Created attachment 224496 [details]
Webkit behavior

[Sudarshan C P]

Created attachment 224499 [details]
Patch

[WebKit Commit Bot]

Attachment 224499 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sudarshan C P]

(In reply to comment #4)
> Created an attachment (id=224499) [details]
> Patch

WIP

[Sudarshan C P]

Created attachment 224500 [details]
Patch

[Build Bot]

Comment on attachment 224500 [details]
Patch

Attachment 224500 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6532200124121088

New failing tests:
fast/repaint/selection-gap-absolute-child.html
fast/repaint/selection-gap-transformed-absolute-child.html
fast/repaint/selection-gap-flipped-absolute-child.html
fast/repaint/selection-gap-transformed-fixed-child.html
fast/block/line-layout/selection-highlight-overlap.html

[Build Bot]

Created attachment 224505 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 224500 [details]
Patch

Attachment 224500 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4512801796128768

New failing tests:
fast/repaint/selection-gap-transformed-fixed-child.html
fast/repaint/selection-gap-fixed-child.html
fast/repaint/selection-gap-flipped-absolute-child.html
fast/repaint/selection-gap-flipped-fixed-child.html
fast/block/line-layout/selection-highlight-overlap.html
fast/repaint/selection-gap-absolute-child.html
fast/repaint/selection-gap-transformed-absolute-child.html

[Build Bot]

Created attachment 224506 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 224500 [details]
Patch

Attachment 224500 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5335931473100800

New failing tests:
fast/repaint/selection-gap-transformed-fixed-child.html
fast/repaint/selection-gap-fixed-child.html
fast/repaint/selection-gap-flipped-absolute-child.html
fast/repaint/selection-gap-flipped-fixed-child.html
fast/block/line-layout/selection-highlight-overlap.html
fast/repaint/selection-gap-absolute-child.html
fast/repaint/selection-gap-transformed-absolute-child.html

[Build Bot]

Created attachment 224514 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Sudarshan C P]

Created attachment 224618 [details]
Patch

[Sudarshan C P]

Fixed in latest binary please close the bug.

[Sudarshan C P]

Fixed in latest binary please close the bug.

[zalan]

Add a test case, please!

[Sudarshan C P]

Thanks for updating the command,i will upload the test case ASAP.

[Sudarshan C P]

Created attachment 225765 [details]
Patch

[Sudarshan C P]

(In reply to comment #17)
> Add a test case, please!
I have uploaded the test case could you please review

[Simon Fraser (smfr)]

Comment on attachment 225765 [details]
Patch

There is no code change in this patch.

[Sudarshan C P]

(In reply to comment #21)
> (From update of attachment 225765 [details])
> There is no code change in this patch.

reported issue is indirectly fixed in latest binary, so reviewer expected to upload the test case, hence added the layout test case to close the issue,Please review the test case.

[Ahmad Saleem]

Marking this as "Duplicate" since the text selection in flexbox and grid was fixed and now in Safari 16.4 Beta 1.

*** This bug has been marked as a duplicate of bug 119878 ***