Bug 128963 - Web Inspector: color picker sliders sometime look wrong on Retina display
Summary: Web Inspector: color picker sliders sometime look wrong on Retina display
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-02-18 02:32 PST by Antoine Quint
Modified: 2014-02-18 08:08 PST (History)
5 users (show)

See Also:

Attachments
Screenshot highlighting the issue (283.96 KB, image/png)
2014-02-18 02:32 PST, Antoine Quint 		no flags Details
Patch (2.08 KB, patch)
2014-02-18 02:34 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2014-02-18 02:32:23 PST 
Created attachment 224485 [details]
Screenshot highlighting the issue

See the attached screenshot and notice how the gradient background of the hue slider is mis-aligned. This is due to the containing popover being set to use a floating top value in this case. We should ensure popovers are using integer values for their position.
Comment 1 Radar WebKit Bug Importer 2014-02-18 02:32:49 PST 
<rdar://problem/16095770>
Comment 2 Antoine Quint 2014-02-18 02:34:24 PST 
Created attachment 224486 [details]
Patch
Comment 3 WebKit Commit Bot 2014-02-18 08:08:09 PST 
Comment on attachment 224486 [details]
Patch

Clearing flags on attachment: 224486

Committed r164292: <http://trac.webkit.org/changeset/164292>
Comment 4 WebKit Commit Bot 2014-02-18 08:08:12 PST 
All reviewed patches have been landed.  Closing bug.