Bug 128961 - [EFL][CMake] Fix javascriptcore test failings by the jsCStack branch merge
Summary: [EFL][CMake] Fix javascriptcore test failings by the jsCStack branch merge
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 127777
  Show dependency tree / graph
 
Reported: 2014-02-18 01:31 PST by Gyuyoung Kim
Modified: 2014-02-18 21:26 PST (History)
6 users (show)

See Also:

Attachments
Patch (2.39 KB, patch)
2014-02-18 01:33 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (2.67 KB, patch)
2014-02-18 20:26 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2014-02-18 01:31:16 PST 
Javascriptcore test on EFL port has been broken since the jsCStack branch merge. For now we can fix almost tests by using "-fno-tree-dce option". Unfortunately, EFL port needs not to check "uninitialized" build warning as error in order to adjust the option to EFL port. This patch don't take it as error temporarily.
Comment 1 Gyuyoung Kim 2014-02-18 01:33:48 PST 
Created attachment 224480 [details]
Patch
Comment 2 Gyuyoung Kim 2014-02-18 01:34:24 PST 
Need to land after checking on EFL bots. CC'ing Ossy.
Comment 3 Gyuyoung Kim 2014-02-18 20:26:24 PST 
Created attachment 224581 [details]
Patch
Comment 4 Gyuyoung Kim 2014-02-18 20:27:07 PST 
I test this patch on EFL bots. 23 errors are disappeared. Please review this patch.
Comment 5 Ryosuke Niwa 2014-02-18 20:50:00 PST 
Comment on attachment 224581 [details]
Patch

rs=me.
Comment 6 WebKit Commit Bot 2014-02-18 21:26:46 PST 
Comment on attachment 224581 [details]
Patch

Clearing flags on attachment: 224581

Committed r164353: <http://trac.webkit.org/changeset/164353>
Comment 7 WebKit Commit Bot 2014-02-18 21:26:49 PST 
All reviewed patches have been landed.  Closing bug.