Bug 128956 - [Cocoa] Implement -description in some API objects
Summary: [Cocoa] Implement -description in some API objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-17 23:35 PST by mitz
Modified: 2014-02-18 11:31 PST (History)
1 user (show)

See Also:


Attachments
Implement -description in UIProcess/API/Cocoa and Shared/API/Cocoa (6.53 KB, patch)
2014-02-17 23:37 PST, mitz
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-02-17 23:35:33 PST
[Cocoa] Implement -description in some API objects
Comment 1 mitz 2014-02-17 23:37:42 PST
Created attachment 224475 [details]
Implement -description in UIProcess/API/Cocoa and Shared/API/Cocoa
Comment 2 Anders Carlsson 2014-02-18 11:27:13 PST
Comment on attachment 224475 [details]
Implement -description in UIProcess/API/Cocoa and Shared/API/Cocoa

View in context: https://bugs.webkit.org/attachment.cgi?id=224475&action=review

> Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectInterface.mm:146
> +    return [NSString stringWithFormat:@"<%@: %p; protocol = \"%@\"; identifier = \"%@\">", NSStringFromClass([self class]), self, _identifier, NSStringFromProtocol(_protocol)];

Please use self.class instead of [self class].

> Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfo.mm:53
> +    return [NSString stringWithFormat:@"<%@: %p; isMainFrame = %d; request = %@>", NSStringFromClass([self class]), self, _mainFrame, _request.get()];

Please use self.class instead of [self class]. I think you should return either YES or NO for the main frame bit.

> Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.mm:41
> +    return [NSString stringWithFormat:@"<%@: %p; navigationType = %ld; request = %@; sourceFrame = %@; destinationFrame = %@>", NSStringFromClass([self class]), self,

Please use self.class instead of [self class].

> Source/WebKit2/UIProcess/API/Cocoa/WKNavigationResponse.mm:40
> +    return [NSString stringWithFormat:@"<%@: %p; frame = %@; response = %@>", NSStringFromClass([self class]), self, _frame.get(), _response.get()];

Please use self.class instead of [self class].

> Source/WebKit2/UIProcess/API/Cocoa/WKProcessClass.mm:83
> +    return [NSString stringWithFormat:@"<%@: %p; configuration = %@>", NSStringFromClass([self class]), self, _configuration.get()];

Please use self.class instead of [self class].

> Source/WebKit2/UIProcess/API/Cocoa/WKProcessClassConfiguration.mm:49
> +    NSString *description = [NSString stringWithFormat:@"<%@: %p; maximumProcessCount = %ld", NSStringFromClass([self class]), self, _maximumProcessCount];

Please use self.class instead of [self class].

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:42
> +    return [NSString stringWithFormat:@"<%@: %p; processClass = %@; preferences = %@>", NSStringFromClass([self class]), self, _processClass.get(), _preferences.get()];

Please use self.class instead of [self class].
Comment 3 mitz 2014-02-18 11:31:39 PST
Committed <http://trac.webkit.org/r164300>.