Bug 128949 – setSelectionRange should set selection without validation

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Ryosuke Niwa]

Since all text nodes and br elements are visible inside text form control elements,
we don't have to validate manually to set selection once we call positionForIndex in setSelectionRange.

This would avoid triggering synchronous layout.

[Ryosuke Niwa]

Created attachment 224460 [details]
Fixes the bug

[Build Bot]

Comment on attachment 224460 [details]
Fixes the bug

Attachment 224460 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6464277095383040

New failing tests:
platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2.html
platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1.html

[Build Bot]

Created attachment 224464 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Ryosuke Niwa]

Created attachment 224465 [details]
Removed ML specific expected results

[Build Bot]

Comment on attachment 224465 [details]
Removed ML specific expected results

Attachment 224465 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6209633853112320

New failing tests:
platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2.html
platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1.html

[Build Bot]

Created attachment 224469 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 224465 [details]
Removed ML specific expected results

Attachment 224465 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5680356980162560

New failing tests:
platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2.html
platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1.html

[Build Bot]

Created attachment 224473 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 224465 [details]
Removed ML specific expected results

Attachment 224465 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4696077714325504

New failing tests:
platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2.html
platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1.html

[Build Bot]

Created attachment 224474 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Ryosuke Niwa]

Created attachment 224528 [details]
Fix ML for the last time

[Enrica Casucci]

Comment on attachment 224528 [details]
Fix ML for the last time

View in context: https://bugs.webkit.org/attachment.cgi?id=224528&action=review

Looks ok to me.

> Source/WebCore/dom/Position.h:-279
> -    return Position(Position::findParent(node), node->nodeIndex(), Position::PositionIsOffsetInAnchor);

Should you ASSERT node->parentNode() here too?

[Ryosuke Niwa]

Comment on attachment 224528 [details]
Fix ML for the last time

View in context: https://bugs.webkit.org/attachment.cgi?id=224528&action=review

>> Source/WebCore/dom/Position.h:-279
>> -    return Position(Position::findParent(node), node->nodeIndex(), Position::PositionIsOffsetInAnchor);
> 
> Should you ASSERT node->parentNode() here too?

The comment above it says why we can't assert it here but I'll check if it's still the case.

[Ryosuke Niwa]

Committed r164316: <http://trac.webkit.org/changeset/164316>