RESOLVED FIXED Bug 128926
[Win] Fall back to Windows symbol servers when necessary 
https://bugs.webkit.org/show_bug.cgi?id=128926
Summary [Win] Fall back to Windows symbol servers when necessary
Brent Fulgham
Reported 2014-02-17 12:01:55 PST
I noticed that our test bots were not generating crash dumps because the _NT_SYMBOL_PATH environment variable was not always properly defined on our test bots. A better solution is to fall back to using the Microsoft Symbol Servers in this case, rather than failing to generate dump files. The only downside is some increased test latency due to having to query and download symbols (on demand) from MSDN when symbols are not available locally.
Attachments
Patch (1.51 KB, patch)
2014-02-17 12:04 PST, Brent Fulgham 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2014-02-17 12:04:37 PST
Created attachment 224411 [details] Patch
Brent Fulgham
Comment 2 2014-02-17 12:20:23 PST
Committed r164244: <http://trac.webkit.org/changeset/164244>
Ryosuke Niwa
Comment 3 2014-02-17 13:35:04 PST
Fixed webkitpy tests on Mac in http://trac.webkit.org/changeset/164247.
Note You need to log in before you can comment on or make changes to this bug.