Bug 128926 - [Win] Fall back to Windows symbol servers when necessary
Summary: [Win] Fall back to Windows symbol servers when necessary
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-17 12:01 PST by Brent Fulgham
Modified: 2014-02-17 13:35 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.51 KB, patch)
2014-02-17 12:04 PST, Brent Fulgham 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-02-17 12:01:55 PST 
I noticed that our test bots were not generating crash dumps because the _NT_SYMBOL_PATH environment variable was not always properly defined on our test bots.

A better solution is to fall back to using the Microsoft Symbol Servers in this case, rather than failing to generate dump files. The only downside is some increased test latency due to having to query and download symbols (on demand) from MSDN when symbols are not available locally.
Comment 1 Brent Fulgham 2014-02-17 12:04:37 PST 
Created attachment 224411 [details]
Patch
Comment 2 Brent Fulgham 2014-02-17 12:20:23 PST 
Committed r164244: <http://trac.webkit.org/changeset/164244>
Comment 3 Ryosuke Niwa 2014-02-17 13:35:04 PST 
Fixed webkitpy tests on Mac in http://trac.webkit.org/changeset/164247.