WebKitGTK+ should stop calling functions to set the view source mode
Created attachment 224399 [details] Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment on attachment 224399 [details] Patch We should also mark the methods as deprecated in both APIs and the WebKitViewMode too in the WebKit2 API. But that shouldn't block this, I can do it in a follow up patch
Comment on attachment 224399 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224399&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:3036 > if (webView->priv->viewMode == viewMode) > return; You should remove this as well
Committed r164235: <http://trac.webkit.org/changeset/164235>