Bug 128919 - WebKitGTK+ should stop calling functions to set the view source mode
Summary: WebKitGTK+ should stop calling functions to set the view source mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-17 11:10 PST by Anders Carlsson
Modified: 2014-02-17 11:21 PST (History)
5 users (show)

See Also:


Attachments
Patch (4.48 KB, patch)
2014-02-17 11:12 PST, Anders Carlsson
cgarcia: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-02-17 11:10:27 PST
WebKitGTK+ should stop calling functions to set the view source mode
Comment 1 Anders Carlsson 2014-02-17 11:12:28 PST
Created attachment 224399 [details]
Patch
Comment 2 WebKit Commit Bot 2014-02-17 11:14:32 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2014-02-17 11:18:41 PST
Comment on attachment 224399 [details]
Patch

We should also mark the methods as deprecated in both APIs and the WebKitViewMode too in the WebKit2 API. But that shouldn't block this, I can do it in a follow up patch
Comment 4 Carlos Garcia Campos 2014-02-17 11:20:48 PST
Comment on attachment 224399 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224399&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:3036
>      if (webView->priv->viewMode == viewMode)
>          return;

You should remove this as well
Comment 5 Anders Carlsson 2014-02-17 11:21:46 PST
Committed r164235: <http://trac.webkit.org/changeset/164235>