http://trac.webkit.org/changeset/163760 " Never include *Inlines.h files in interface headers, and never include *Inlines.h when you could include Operations.h instead" This changeset moved many primary header inclusion after the #if ENABLE(...) guard without any profit and added zillion webkit style violations pointlessly. The discussion started about it in the original bug report: https://bugs.webkit.org/show_bug.cgi?id=128505#c26 original code was ------------------ #include "config.h" #include "Blah.h" #if ENABLE(...) new code is: ------------- #include "config.h" #if ENABLE(...) #include "Blah.h" -------------------------------------------------------------------------------------- It was a false presumption if this kind of change fixed the EFL build, because ENABLE(JIT) and ENABLE(DFG_JIT) are always true on EFL. Additionally almost all of these headers are guarded properly, we really don't need one more guard for the include. I'm going to revert this unrelated noise.
Created attachment 224371 [details] Patch
Additionally it doesn't affect the DFG and the non-DFG builds ( after non-DFG build is fixed in Source/JavaScriptCore/jit/Repatch.cpp once in bug128549 )
Comment on attachment 224371 [details] Patch Clearing flags on attachment: 224371 Committed r164229: <http://trac.webkit.org/changeset/164229>
All reviewed patches have been landed. Closing bug.