Bug 128912 - Move back primary header includes next to config.h
Summary: Move back primary header includes next to config.h
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
Depends on:
Reported: 2014-02-17 08:13 PST by Csaba Osztrogonác
Modified: 2014-02-17 10:54 PST (History)
2 users (show)

See Also:

Patch (61.79 KB, patch)
2014-02-17 08:16 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2014-02-17 08:13:34 PST
http://trac.webkit.org/changeset/163760 " Never include *Inlines.h files in interface 
headers, and never include *Inlines.h when you could include Operations.h instead"

This changeset moved many primary header inclusion after the #if ENABLE(...) guard
without any profit and added zillion webkit style violations pointlessly.

The discussion started about it in the original bug report:

original code was
#include "config.h"
#include "Blah.h"

#if ENABLE(...)

new code is:
#include "config.h"

#if ENABLE(...)

#include "Blah.h"


It was a false presumption if this kind of change fixed the EFL build,
because ENABLE(JIT) and ENABLE(DFG_JIT) are always true on EFL.

Additionally almost all of these headers are guarded properly, 
we really don't need one more guard for the include.

I'm going to revert this unrelated noise.
Comment 1 Csaba Osztrogonác 2014-02-17 08:16:26 PST
Created attachment 224371 [details]
Comment 2 Csaba Osztrogonác 2014-02-17 08:18:47 PST
Additionally it doesn't affect the DFG and the non-DFG builds ( after non-DFG
build is fixed in Source/JavaScriptCore/jit/Repatch.cpp once in bug128549 )
Comment 3 WebKit Commit Bot 2014-02-17 10:54:51 PST
Comment on attachment 224371 [details]

Clearing flags on attachment: 224371

Committed r164229: <http://trac.webkit.org/changeset/164229>
Comment 4 WebKit Commit Bot 2014-02-17 10:54:54 PST
All reviewed patches have been landed.  Closing bug.