Bug 128909 - Web Inspector: CSS selectors containing a color name shouldn't be considered for color editing
Summary: Web Inspector: CSS selectors containing a color name shouldn't be considered ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-02-17 07:08 PST by Antoine Quint
Modified: 2014-02-17 11:30 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.72 KB, patch)
2014-02-17 08:44 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2014-02-17 07:08:17 PST 
If you have a CSS selector like #facebook, the #fac part of the selector is recognised as a color in the CSS resource and hovering the string will show a hover menu to edit the text as a color. This doesn't make sense, this type of UI should be reserved for CSS properties.
Comment 1 Radar WebKit Bug Importer 2014-02-17 07:08:59 PST 
<rdar://problem/16083842>
Comment 2 Antoine Quint 2014-02-17 08:44:06 PST 
Created attachment 224378 [details]
Patch
Comment 3 Joseph Pecoraro 2014-02-17 11:02:59 PST 
Comment on attachment 224378 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2014-02-17 11:30:47 PST 
Comment on attachment 224378 [details]
Patch

Clearing flags on attachment: 224378

Committed r164236: <http://trac.webkit.org/changeset/164236>
Comment 5 WebKit Commit Bot 2014-02-17 11:30:49 PST 
All reviewed patches have been landed.  Closing bug.