RESOLVED FIXED 128903
[XHR] Cache response JS object in case of arraybuffer and blob response types 
https://bugs.webkit.org/show_bug.cgi?id=128903
Summary [XHR] Cache response JS object in case of arraybuffer and blob response types
youenn fablet
Reported 2014-02-17 05:36:39 PST
XHR currently cache response object when responseType is json. This can also be done for other types as well (arraybuffer and blob notably) as a small optimization step.
Attachments
Patch (15.31 KB, patch)
2014-02-17 05:56 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
WIP (9.57 KB, patch)
2016-07-19 02:33 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
WIP2 (14.70 KB, patch)
2016-07-19 02:53 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (20.13 KB, patch)
2016-07-19 05:13 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-yosemite (797.26 KB, application/zip)
2016-07-19 06:09 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (784.76 KB, application/zip)
2016-07-19 06:13 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (637.74 KB, application/zip)
2016-07-19 06:18 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews116 for mac-yosemite (1.43 MB, application/zip)
2016-07-19 06:18 PDT, Build Bot 		no flags
Details
Fixing responseText (20.44 KB, patch)
2016-07-19 06:47 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (20.42 KB, patch)
2016-07-20 23:21 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2014-02-17 05:56:12 PST
Created attachment 224361 [details] Patch
youenn fablet
Comment 2 2016-07-19 02:33:19 PDT
Created attachment 283987 [details] WIP
youenn fablet
Comment 3 2016-07-19 02:53:06 PDT
Created attachment 283988 [details] WIP2
youenn fablet
Comment 4 2016-07-19 05:13:47 PDT
Created attachment 283992 [details] Patch
Build Bot
Comment 5 2016-07-19 06:09:14 PDT
Comment on attachment 283992 [details] Patch Attachment 283992 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1706634 New failing tests: fast/xmlhttprequest/xmlhttprequest-responsetype-text.html
Build Bot
Comment 6 2016-07-19 06:09:16 PDT
Created attachment 283995 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 7 2016-07-19 06:13:03 PDT
Comment on attachment 283992 [details] Patch Attachment 283992 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1706641 New failing tests: fast/xmlhttprequest/xmlhttprequest-responsetype-text.html
Build Bot
Comment 8 2016-07-19 06:13:05 PDT
Created attachment 283996 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 9 2016-07-19 06:17:59 PDT
Comment on attachment 283992 [details] Patch Attachment 283992 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1706637 New failing tests: fast/xmlhttprequest/xmlhttprequest-responsetype-text.html
Build Bot
Comment 10 2016-07-19 06:18:02 PDT
Created attachment 283997 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.5
Build Bot
Comment 11 2016-07-19 06:18:34 PDT
Comment on attachment 283992 [details] Patch Attachment 283992 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1706640 New failing tests: fast/xmlhttprequest/xmlhttprequest-responsetype-text.html
Build Bot
Comment 12 2016-07-19 06:18:37 PDT
Created attachment 283998 [details] Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
youenn fablet
Comment 13 2016-07-19 06:47:28 PDT
Created attachment 284002 [details] Fixing responseText
WebKit Commit Bot
Comment 14 2016-07-20 22:51:38 PDT
Comment on attachment 284002 [details] Fixing responseText Rejecting attachment 284002 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 284002, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: dl Hunk #2 succeeded at 80 (offset 2 lines). patching file Source/WebCore/xml/XMLHttpRequest.js patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/http/tests/xmlhttprequest/onabort-response-getters-expected.txt patching file LayoutTests/http/tests/xmlhttprequest/onabort-response-getters.html Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alex Christensen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/1721214
youenn fablet
Comment 15 2016-07-20 23:21:10 PDT
Created attachment 284193 [details] Patch for landing
WebKit Commit Bot
Comment 16 2016-07-20 23:52:03 PDT
Comment on attachment 284193 [details] Patch for landing Clearing flags on attachment: 284193 Committed r203494: <http://trac.webkit.org/changeset/203494>
WebKit Commit Bot
Comment 17 2016-07-20 23:52:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.