NEW 128896
TextAutosizer: avoid unnecessary calls to containerShouldBeAutosized. 
https://bugs.webkit.org/show_bug.cgi?id=128896
Summary TextAutosizer: avoid unnecessary calls to containerShouldBeAutosized.
Laszlo Vidacs
Reported 2014-02-17 02:32:09 PST
Blink merge candidate: https://codereview.chromium.org/134153006/ by timvolodine This patch adds a simple check to ensure that the multiplier > 1 before calling containerShouldBeAutosized() inside processContainer(). If the multiplier is exactly 1 the return value of containerShouldBeAutosized does not matter. Due to the cascading structure of the algorithm quite a few unnecessary calls to containerShouldBeAutosized are avoided in this way, reducing the text autosizing times by up to 30% on some websites.
Attachments
Patch (1.64 KB, patch)
2014-02-17 02:38 PST, Laszlo Vidacs 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Vidacs
Comment 1 2014-02-17 02:38:50 PST
Created attachment 224348 [details] Patch
Michael Catanzaro
Comment 2 2016-09-17 07:17:49 PDT
Comment on attachment 224348 [details] Patch Hi, Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting. To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug.
Note You need to log in before you can comment on or make changes to this bug.