Bug 128896 - TextAutosizer: avoid unnecessary calls to containerShouldBeAutosized.
Summary: TextAutosizer: avoid unnecessary calls to containerShouldBeAutosized.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2014-02-17 02:32 PST by Laszlo Vidacs
Modified: 2016-09-17 07:17 PDT (History)
9 users (show)

See Also:

Attachments
Patch (1.64 KB, patch)
2014-02-17 02:38 PST, Laszlo Vidacs 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Vidacs 2014-02-17 02:32:09 PST 
Blink merge candidate: https://codereview.chromium.org/134153006/ by timvolodine

This patch adds a simple check to ensure that the multiplier > 1 before calling containerShouldBeAutosized() inside processContainer().
If the multiplier is exactly 1 the return value of containerShouldBeAutosized does not matter. Due to the cascading structure of the algorithm quite a few unnecessary calls to containerShouldBeAutosized are avoided in this way, reducing the text autosizing times by up to 30% on some websites.
Comment 1 Laszlo Vidacs 2014-02-17 02:38:50 PST 
Created attachment 224348 [details]
Patch
Comment 2 Michael Catanzaro 2016-09-17 07:17:49 PDT 
Comment on attachment 224348 [details]
Patch

Hi,

Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting.

To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug.