Bug 128894 - Rename EXT_draw_buffers to WEBGL_draw_buffers
Summary: Rename EXT_draw_buffers to WEBGL_draw_buffers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: ChangSeok Oh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-17 01:32 PST by ChangSeok Oh
Modified: 2016-03-22 13:41 PDT (History)
15 users (show)

See Also:

Attachments
Patch (91.51 KB, patch)
2014-02-18 22:01 PST, ChangSeok Oh 		no flags Details | Formatted Diff | Diff
Patch (178.47 KB, patch)
2014-02-19 01:28 PST, ChangSeok Oh 		no flags Details | Formatted Diff | Diff
Patch (193.45 KB, patch)
2014-02-19 01:44 PST, ChangSeok Oh 		no flags Details | Formatted Diff | Diff
Patch (129.24 KB, patch)
2014-02-19 08:24 PST, ChangSeok Oh 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (470.63 KB, application/zip)
2014-02-19 09:23 PST, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (499.55 KB, application/zip)
2014-02-19 09:42 PST, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (501.39 KB, application/zip)
2014-02-19 10:48 PST, Build Bot 		no flags Details
Patch (142.00 KB, patch)
2014-02-19 20:38 PST, ChangSeok Oh 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (473.13 KB, application/zip)
2014-02-19 21:37 PST, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (499.76 KB, application/zip)
2014-02-19 22:02 PST, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (502.01 KB, application/zip)
2014-02-19 23:02 PST, Build Bot 		no flags Details
Patch (143.05 KB, patch)
2014-02-19 23:51 PST, ChangSeok Oh 		dino: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch (143.01 KB, patch)
2014-02-20 22:26 PST, ChangSeok Oh 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 ChangSeok Oh 2014-02-18 22:01:23 PST 
Created attachment 224593 [details]
Patch
Comment 2 ChangSeok Oh 2014-02-19 01:28:52 PST 
Created attachment 224609 [details]
Patch
Comment 3 ChangSeok Oh 2014-02-19 01:44:11 PST 
Created attachment 224611 [details]
Patch
Comment 4 ChangSeok Oh 2014-02-19 02:16:21 PST 
Comment on attachment 224611 [details]
Patch

updating webgl-test-utils causes so many failures.
Comment 5 ChangSeok Oh 2014-02-19 08:24:34 PST 
Created attachment 224633 [details]
Patch
Comment 6 Build Bot 2014-02-19 09:23:34 PST 
Comment on attachment 224633 [details]
Patch

Attachment 224633 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5168469892923392

New failing tests:
fast/ruby/ruby-base-merge-block-children-crash-2.html
fast/canvas/webgl/webgl-draw-buffers.html
Comment 7 Build Bot 2014-02-19 09:23:37 PST 
Created attachment 224636 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 8 Build Bot 2014-02-19 09:42:40 PST 
Comment on attachment 224633 [details]
Patch

Attachment 224633 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6625096777072640

New failing tests:
fast/ruby/ruby-base-merge-block-children-crash-2.html
fast/canvas/webgl/webgl-draw-buffers.html
Comment 9 Build Bot 2014-02-19 09:42:44 PST 
Created attachment 224641 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 10 Build Bot 2014-02-19 10:48:10 PST 
Comment on attachment 224633 [details]
Patch

Attachment 224633 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5357618642026496

New failing tests:
fast/ruby/ruby-base-merge-block-children-crash-2.html
fast/canvas/webgl/webgl-draw-buffers.html
Comment 11 Build Bot 2014-02-19 10:48:14 PST 
Created attachment 224653 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 12 ChangSeok Oh 2014-02-19 20:38:19 PST 
Created attachment 224702 [details]
Patch
Comment 13 Build Bot 2014-02-19 21:37:08 PST 
Comment on attachment 224702 [details]
Patch

Attachment 224702 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4550544358113280

New failing tests:
fast/canvas/webgl/webgl-draw-buffers.html
Comment 14 Build Bot 2014-02-19 21:37:11 PST 
Created attachment 224704 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 15 Build Bot 2014-02-19 22:02:44 PST 
Comment on attachment 224702 [details]
Patch

Attachment 224702 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5370810902511616

New failing tests:
fast/canvas/webgl/webgl-draw-buffers.html
Comment 16 Build Bot 2014-02-19 22:02:49 PST 
Created attachment 224711 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 17 Build Bot 2014-02-19 23:01:58 PST 
Comment on attachment 224702 [details]
Patch

Attachment 224702 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6725992538177536

New failing tests:
fast/canvas/webgl/webgl-draw-buffers.html
Comment 18 Build Bot 2014-02-19 23:02:04 PST 
Created attachment 224717 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 19 ChangSeok Oh 2014-02-19 23:51:18 PST 
Created attachment 224722 [details]
Patch
Comment 20 ChangSeok Oh 2014-02-20 20:48:31 PST 
Comment on attachment 224722 [details]
Patch

Thanks!
Comment 21 WebKit Commit Bot 2014-02-20 20:50:28 PST 
Comment on attachment 224722 [details]
Patch

Rejecting attachment 224722 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 224722, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
anvas/webgl/resources/webgl-test-utils.js
patching file LayoutTests/fast/canvas/webgl/webgl-draw-buffers-expected.txt
patching file LayoutTests/fast/canvas/webgl/webgl-draw-buffers.html
patching file LayoutTests/platform/mac-mountainlion/fast/canvas/webgl/webgl-draw-buffers-expected.txt
patching file LayoutTests/platform/mac/TestExpectations

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Dean Jackson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/4641073141907456
Comment 22 ChangSeok Oh 2014-02-20 22:26:28 PST 
Created attachment 224833 [details]
Patch
Comment 23 WebKit Commit Bot 2014-02-20 23:41:12 PST 
Comment on attachment 224833 [details]
Patch

Clearing flags on attachment: 224833

Committed r164477: <http://trac.webkit.org/changeset/164477>