Bug 128881 - setSelectionRange shouldn't directly instantiate VisibleSelection
Summary: setSelectionRange shouldn't directly instantiate VisibleSelection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 127832
  Show dependency tree / graph
 
Reported: 2014-02-15 20:19 PST by Ryosuke Niwa
Modified: 2014-02-16 13:55 PST (History)
1 user (show)

See Also:

Attachments
Fixes the bug (4.21 KB, patch)
2014-02-15 20:22 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2014-02-15 20:19:18 PST 
This triggers synchronous layout.
Comment 1 Ryosuke Niwa 2014-02-15 20:20:05 PST 
The scope of this bug is to encapsulate the instantiation of VisibleSelection into FrameSelection so that we may optimize them away later.
Comment 2 Ryosuke Niwa 2014-02-15 20:22:30 PST 
Created attachment 224313 [details]
Fixes the bug
Comment 3 Andreas Kling 2014-02-16 13:24:27 PST 
Comment on attachment 224313 [details]
Fixes the bug

r=me
Comment 4 WebKit Commit Bot 2014-02-16 13:55:11 PST 
Comment on attachment 224313 [details]
Fixes the bug

Clearing flags on attachment: 224313

Committed r164194: <http://trac.webkit.org/changeset/164194>
Comment 5 WebKit Commit Bot 2014-02-16 13:55:13 PST 
All reviewed patches have been landed.  Closing bug.