Bug 128879 - DOMSelection shouldn't instantiate VisibleSelection everywhere
Summary: DOMSelection shouldn't instantiate VisibleSelection everywhere
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 127832
  Show dependency tree / graph
 
Reported: 2014-02-15 19:11 PST by Ryosuke Niwa
Modified: 2014-02-15 19:29 PST (History)
5 users (show)

See Also:

Attachments
Cleanup (6.21 KB, patch)
2014-02-15 19:13 PST, Ryosuke Niwa 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2014-02-15 19:11:31 PST 
Right now, various member functions of DOMSelection instantiates VisibleSelection.
This would mean that all those functions are triggering synchronous layout at that point.

Defer those synchronous layout until FrameSelection's member functions are called
so that we may optimize them later in the bug 127832.
Comment 1 Ryosuke Niwa 2014-02-15 19:12:12 PST 
This change is needed to increase the test coverage of asynchronous selection because we don't have that many tests for selection inside text fields.
Comment 2 Ryosuke Niwa 2014-02-15 19:13:11 PST 
Created attachment 224307 [details]
Cleanup
Comment 3 Ryosuke Niwa 2014-02-15 19:29:52 PST 
Committed r164188: <http://trac.webkit.org/changeset/164188>