RESOLVED FIXED128871
[ASan] WebKit1 sources are not compiled using ASAN macros 
https://bugs.webkit.org/show_bug.cgi?id=128871
Summary [ASan] WebKit1 sources are not compiled using ASAN macros
David Kilzer (:ddkilzer)
Reported 2014-02-15 07:04:51 PST
The way the OTHER_CPLUSPLUSFLAGS variable is defined in WebKit.xcconfig doesn't include ASAN_OTHER_CPLUSPLUSFLAGS set in DebugRelease.xcconfig, so not all files are compiled with ASan enabled in WebKit1.
Attachments
Patch v1 (2.76 KB, patch)
2014-02-15 07:06 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2014-02-15 07:06:50 PST
Created attachment 224298 [details] Patch v1
Brent Fulgham
Comment 2 2014-02-19 11:37:08 PST
Comment on attachment 224298 [details] Patch v1 r=me
WebKit Commit Bot
Comment 3 2014-02-20 10:10:27 PST
Comment on attachment 224298 [details] Patch v1 Clearing flags on attachment: 224298 Committed r164434: <http://trac.webkit.org/changeset/164434>
WebKit Commit Bot
Comment 4 2014-02-20 10:10:30 PST
All reviewed patches have been landed. Closing bug.
David Kilzer (:ddkilzer)
Comment 5 2014-02-22 09:27:42 PST
(In reply to comment #3) > (From update of attachment 224298 [details]) > Clearing flags on attachment: 224298 > > Committed r164434: <http://trac.webkit.org/changeset/164434> This change was reverted in r164542: <http://trac.webkit.org/changeset/164542> It actually broke ASan builds when specifying "ARGS=-xcconfig Tools/asan/asan.xcconfig" on the build command-line.
Note You need to log in before you can comment on or make changes to this bug.