WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
128867
Setting currentTime on HTMLMediaElement with media controller should throw exception
https://bugs.webkit.org/show_bug.cgi?id=128867
Summary
Setting currentTime on HTMLMediaElement with media controller should throw ex...
Piotr Grad
Reported
2014-02-15 00:58:41 PST
According to spec. On setting, if the media element has a current media controller, then the user agent must throw an InvalidStateError exception [1] [1]
http://www.w3.org/TR/html51/embedded-content-0.html#dom-media-currenttime
Attachments
Patch & layout test
(5.01 KB, patch)
2014-02-15 03:37 PST
,
Piotr Grad
no flags
Details
Formatted Diff
Diff
Patch & layout test
(4.91 KB, patch)
2014-02-15 03:41 PST
,
Piotr Grad
eric.carlson
: review+
Details
Formatted Diff
Diff
Patch & layout test
(4.85 KB, patch)
2014-02-15 08:39 PST
,
Piotr Grad
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Piotr Grad
Comment 1
2014-02-15 03:37:37 PST
Created
attachment 224296
[details]
Patch & layout test
Piotr Grad
Comment 2
2014-02-15 03:41:14 PST
Created
attachment 224297
[details]
Patch & layout test
Eric Carlson
Comment 3
2014-02-15 08:24:53 PST
Comment on
attachment 224297
[details]
Patch & layout test View in context:
https://bugs.webkit.org/attachment.cgi?id=224297&action=review
> LayoutTests/media/video-controller-currentTime.html:7 > + function start() {
Nit: a function's opening brace should be on a new line.
> LayoutTests/media/video-controller-currentTime.html:13 > + function canPlayThrough() {
Ditto.
> LayoutTests/media/video-controller-currentTime.html:19 > + try { > + video.currentTime = 3; > + } catch (e) { > + consoleWrite(e); > + endTest(); > + }
You should also test that an INVALID_STATE_ERR exception is thrown, eg.: testDOMException("video.currentTime = 3", "DOMException.INVALID_STATE_ERR");
Piotr Grad
Comment 4
2014-02-15 08:39:16 PST
Created
attachment 224299
[details]
Patch & layout test
Eric Carlson
Comment 5
2014-02-15 09:24:53 PST
Comment on
attachment 224299
[details]
Patch & layout test Thank you!
WebKit Commit Bot
Comment 6
2014-02-15 09:55:13 PST
Comment on
attachment 224299
[details]
Patch & layout test Clearing flags on attachment: 224299 Committed
r164174
: <
http://trac.webkit.org/changeset/164174
>
WebKit Commit Bot
Comment 7
2014-02-15 09:55:16 PST
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 8
2014-02-19 10:06:05 PST
Comment on
attachment 224299
[details]
Patch & layout test View in context:
https://bugs.webkit.org/attachment.cgi?id=224299&action=review
> Source/WebCore/html/HTMLMediaElement.h:183 > + virtual void setCurrentTime(double, ExceptionCode&);
I see no reason for this function to be virtual.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug