Bug 128867 – Setting currentTime on HTMLMediaElement with media controller should throw exception

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Piotr Grad]

According to spec. On setting, if the media element has a current media controller, then the user agent must throw an InvalidStateError exception [1]

[1] http://www.w3.org/TR/html51/embedded-content-0.html#dom-media-currenttime

[Piotr Grad]

Created attachment 224296 [details]
Patch & layout test

[Piotr Grad]

Created attachment 224297 [details]
Patch & layout test

[Eric Carlson]

Comment on attachment 224297 [details]
Patch & layout test

View in context: https://bugs.webkit.org/attachment.cgi?id=224297&action=review

> LayoutTests/media/video-controller-currentTime.html:7
> +            function start() {

Nit: a function's opening brace should be on a new line.

> LayoutTests/media/video-controller-currentTime.html:13
> +            function canPlayThrough() {

Ditto.

> LayoutTests/media/video-controller-currentTime.html:19
> +                try {
> +                    video.currentTime = 3;
> +                } catch (e) {
> +                    consoleWrite(e);
> +                    endTest();
> +                }

You should also test that an INVALID_STATE_ERR exception is thrown, eg.:

testDOMException("video.currentTime = 3", "DOMException.INVALID_STATE_ERR");

[Piotr Grad]

Created attachment 224299 [details]
Patch & layout test

[Eric Carlson]

Comment on attachment 224299 [details]
Patch & layout test

Thank you!

[WebKit Commit Bot]

Comment on attachment 224299 [details]
Patch & layout test

Clearing flags on attachment: 224299

Committed r164174: <http://trac.webkit.org/changeset/164174>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 224299 [details]
Patch & layout test

View in context: https://bugs.webkit.org/attachment.cgi?id=224299&action=review

> Source/WebCore/html/HTMLMediaElement.h:183
> +    virtual void setCurrentTime(double, ExceptionCode&);

I see no reason for this function to be virtual.