Bug 128861 - run-webkit-tests doesn't work with Apache 2.4
Summary: run-webkit-tests doesn't work with Apache 2.4
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-14 18:05 PST by Ryosuke Niwa
Modified: 2014-02-14 18:47 PST (History)
8 users (show)

See Also:


Attachments
Fixes the bug (6.96 KB, patch)
2014-02-14 18:07 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Fixes the bug (6.32 KB, patch)
2014-02-14 18:24 PST, Ryosuke Niwa
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2014-02-14 18:05:51 PST
run-webkit-tests doesn't work with Apache 2.4
Comment 1 Ryosuke Niwa 2014-02-14 18:07:23 PST
Created attachment 224271 [details]
Fixes the bug
Comment 2 Alexey Proskuryakov 2014-02-14 18:12:30 PST
Comment on attachment 224271 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=224271&action=review

> Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server.py:144
> +        # FIXME: This is such a hack but we can't invoke httpd in _path_to_apache_config_file.

It would be helpful to explain why exactly this is a hack, and if there are any ideas for how to improve this in the future.

This comment is not very useful as is - someone who understands why it's a hack doesn't need the comment to see that, and someone who doesn't won't get any benefit from it.

> Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server.py:149
> +                if 'Apache/2.4' in process.stdout.read():

What about Apache 2.5+?
Comment 3 Ryosuke Niwa 2014-02-14 18:24:14 PST
Created attachment 224272 [details]
Fixes the bug
Comment 4 Andreas Kling 2014-02-14 18:27:20 PST
Comment on attachment 224272 [details]
Fixes the bug

rs=me
Comment 5 Ryosuke Niwa 2014-02-14 18:34:16 PST
Committed r164148: <http://trac.webkit.org/changeset/164148>
Comment 6 Ryosuke Niwa 2014-02-14 18:45:22 PST
Fixed builds in http://trac.webkit.org/changeset/164149.
Comment 7 Ryosuke Niwa 2014-02-14 18:47:29 PST
Another one: http://trac.webkit.org/changeset/164150