Bug 128859 - [Win] Avoid unnecessary asserts if "prepareToPlay" called multiple times
Summary: [Win] Avoid unnecessary asserts if "prepareToPlay" called multiple times
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
Depends on:
Reported: 2014-02-14 17:49 PST by Brent Fulgham
Modified: 2014-02-15 11:20 PST (History)
7 users (show)

See Also:

Patch (2.11 KB, patch)
2014-02-14 17:50 PST, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-02-14 17:49:01 PST
There seem to be some use cases where the HTMLMediaElement may call "prepareToPlay" more than once. This could happen if asset metadata arrives earlier than expected, or if a web page makes the call multiple times.

Instead of asserting when this happens, just return the existing player item.
Comment 1 Brent Fulgham 2014-02-14 17:50:45 PST
Created attachment 224268 [details]
Comment 2 WebKit Commit Bot 2014-02-15 11:20:40 PST
Comment on attachment 224268 [details]

Clearing flags on attachment: 224268

Committed r164177: <http://trac.webkit.org/changeset/164177>
Comment 3 WebKit Commit Bot 2014-02-15 11:20:43 PST
All reviewed patches have been landed.  Closing bug.