We have a client call to get a WebCrypto master key, but most client won't implement it. WebKit should provide encryption by default. <rdar://problem/15921734>
Created attachment 224262 [details] proposed patch
Created attachment 224267 [details] with less 10.8 build breakage
Comment on attachment 224267 [details] with less 10.8 build breakage View in context: https://bugs.webkit.org/attachment.cgi?id=224267&action=review > Source/WebCore/crypto/mac/SerializedCryptoKeyWrapMac.mm:60 > +static NSString* masterKeyAccountNameForCurrentApplication() > +{ > + return [NSString stringWithFormat:@"com.apple.WebKit.WebCrypto.master+%@", [[NSRunningApplication currentApplication] bundleIdentifier]]; > +} When building for iOS, won’t this cause an unused function warning? > Source/WebCore/crypto/mac/SerializedCryptoKeyWrapMac.mm:100 > + status = SecACLSetContents(acl, (CFArrayRef)@[(id)trustedApp.get()], (CFStringRef)localizedItemName, kSecKeychainPromptRequirePassphase); Please add spaces inside the @[].
Comment on attachment 224267 [details] with less 10.8 build breakage Sorry, I didn’t mean to reset the review flag. This is still r=oliver.
Comment on attachment 224267 [details] with less 10.8 build breakage View in context: https://bugs.webkit.org/attachment.cgi?id=224267&action=review > Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm:1008 > + NSData* keyData = CallUIDelegate(m_webView, selector); Space on the wrong side of the star. > Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm:1021 > + NSData* keyData = CallUIDelegate(m_webView, selector); Here too.
Committed with suggested fixes in <http://trac.webkit.org/r164181>.