Bug 128848 – [Win] Make tests more consistent with Mac platform

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Brent Fulgham]

A number of test differences have crept in to the Windows port during the last year or so of development. This bug brings them back into sync:

1. We should be using Mock scrollbars so we can share common expected output.
2. We should enable CSS Regions in DumpRenderTree, since the tests are being run and the feature is enabled on Windows.
3. It would be nice if we could make antialiasing/font smoothing identical on the two platforms, but it seems like there's still some very small differences.

[Brent Fulgham]

Created attachment 224259 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 224259 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224259&action=review

> Source/WebKit/win/WebPreferences.h:484
> +    virtual HRESULT STDMETHODCALLTYPE screenFontSubstitutionEnabled(BOOL*);
> +    virtual HRESULT STDMETHODCALLTYPE setScreenFontSubstitutionEnabled(BOOL);

I'm not sure this one has any effect on Windows.

> Source/WebKit/win/WebView.cpp:5058
> +    hr = prefsPrivate->screenFontSubstitutionEnabled(&enabled);
> +    if (FAILED(hr))
> +        return hr;
> +    settings.setScreenFontSubstitutionEnabled(enabled);

I think this is a no-op.

> Tools/DumpRenderTree/win/DumpRenderTree.cpp:876
> +    preferences->setCSSRegionsEnabled(TRUE);

Does this mean we can enable a bunch of tests?

[Brent Fulgham]

Landed in http://trac.webkit.org/changeset/164141.

[Radar WebKit Bug Importer]

<rdar://problem/16075979>