Bug 128848 - [Win] Make tests more consistent with Mac platform
Summary: [Win] Make tests more consistent with Mac platform
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
Keywords: InRadar
Depends on:
Reported: 2014-02-14 15:17 PST by Brent Fulgham
Modified: 2014-02-14 16:17 PST (History)
2 users (show)

See Also:

Patch (6.52 KB, patch)
2014-02-14 15:28 PST, Brent Fulgham
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-02-14 15:17:22 PST
A number of test differences have crept in to the Windows port during the last year or so of development. This bug brings them back into sync:

1. We should be using Mock scrollbars so we can share common expected output.
2. We should enable CSS Regions in DumpRenderTree, since the tests are being run and the feature is enabled on Windows.
3. It would be nice if we could make antialiasing/font smoothing identical on the two platforms, but it seems like there's still some very small differences.
Comment 1 Brent Fulgham 2014-02-14 15:28:46 PST
Created attachment 224259 [details]
Comment 2 Simon Fraser (smfr) 2014-02-14 15:35:54 PST
Comment on attachment 224259 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=224259&action=review

> Source/WebKit/win/WebPreferences.h:484
> +    virtual HRESULT STDMETHODCALLTYPE screenFontSubstitutionEnabled(BOOL*);
> +    virtual HRESULT STDMETHODCALLTYPE setScreenFontSubstitutionEnabled(BOOL);

I'm not sure this one has any effect on Windows.

> Source/WebKit/win/WebView.cpp:5058
> +    hr = prefsPrivate->screenFontSubstitutionEnabled(&enabled);
> +    if (FAILED(hr))
> +        return hr;
> +    settings.setScreenFontSubstitutionEnabled(enabled);

I think this is a no-op.

> Tools/DumpRenderTree/win/DumpRenderTree.cpp:876
> +    preferences->setCSSRegionsEnabled(TRUE);

Does this mean we can enable a bunch of tests?
Comment 3 Brent Fulgham 2014-02-14 16:17:06 PST
Landed in http://trac.webkit.org/changeset/164141.
Comment 4 Radar WebKit Bug Importer 2014-02-14 16:17:45 PST