Bug 128845 - Expose a way to clear cookies modified after a given date
Summary: Expose a way to clear cookies modified after a given date
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-14 14:22 PST by Ricky Mondello
Modified: 2014-09-15 04:17 PDT (History)
11 users (show)

See Also:

Attachments
Patch (12.22 KB, patch)
2014-02-14 17:57 PST, Ricky Mondello 		no flags Details | Formatted Diff | Diff
Does this fix the GTK build? (12.99 KB, patch)
2014-02-14 18:35 PST, Ricky Mondello 		no flags Details | Formatted Diff | Diff
Addressing Jessie's feedback (14.51 KB, patch)
2014-02-17 13:56 PST, Ricky Mondello 		no flags Details | Formatted Diff | Diff
Same as the last patch, but name the category (14.58 KB, patch)
2014-02-17 20:24 PST, Ricky Mondello 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ricky Mondello 2014-02-14 14:22:07 PST 
It'd be useful to have a way to remove cookies that were added after a given point in time.
Comment 1 Ricky Mondello 2014-02-14 17:57:44 PST 
Created attachment 224269 [details]
Patch
Comment 2 Ricky Mondello 2014-02-14 18:35:27 PST 
Created attachment 224273 [details]
Does this fix the GTK build?
Comment 3 Jessie Berlin 2014-02-17 09:24:50 PST 
Comment on attachment 224273 [details]
Does this fix the GTK build?

View in context: https://bugs.webkit.org/attachment.cgi?id=224273&action=review

One of the reasons the GTK and EFL builds are broken is that you added a method declaration to PlatformCookieJar.h but only added an implementation to Source/WebCore/platform/network/cf/CookieJarCFNet.cpp and Source/WebCore/platform/network/mac/CookieJarMac.mm. You also need to add a stub implementation to the soup/CookieJarSoup.cpp implementation and possibly to the curl/CookieJarCurl.cpp implementation.

> Source/WebCore/platform/network/cf/CookieJarCFNet.cpp:242
> +void deleteAllCookies(const NetworkStorageSession&)

This is one of the reasons the Windows build is broken:

     1>..\platform\network\cf\CookieJarCFNet.cpp(243): error C2084: function 'void WebCore::deleteAllCookies(const WebCore::NetworkStorageSession &)' already has a body
                 C:\cygwin\home\buildbot\WebKit\Source\WebCore\platform\network\PlatformCookieJar.h(50) : see previous definition of 'deleteAllCookies'

You probably meant

void deleteAllCookiesModifiedAfterDate(const NetworkStorageSession&, double)

instead
Comment 4 Ricky Mondello 2014-02-17 13:56:43 PST 
Created attachment 224421 [details]
Addressing Jessie's feedback
Comment 5 Alexey Proskuryakov 2014-02-17 16:38:00 PST 
Comment on attachment 224421 [details]
Addressing Jessie's feedback

View in context: https://bugs.webkit.org/attachment.cgi?id=224421&action=review

> Source/WebCore/platform/network/mac/CookieJarMac.mm:42
> +@interface NSHTTPCookieStorage ()

I thought that we used named categories for these things:

@interface NSHTTPCookieStorage (Details)
Comment 6 Ricky Mondello 2014-02-17 16:38:42 PST 
(In reply to comment #5)
> (From update of attachment 224421 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=224421&action=review
> 
> > Source/WebCore/platform/network/mac/CookieJarMac.mm:42
> > +@interface NSHTTPCookieStorage ()
> 
> I thought that we used named categories for these things:
> 
> @interface NSHTTPCookieStorage (Details)

We do and should! I'll post another patch.
Comment 7 Ricky Mondello 2014-02-17 20:24:04 PST 
Created attachment 224461 [details]
Same as the last patch, but name the category
Comment 8 WebKit Commit Bot 2014-02-17 21:13:06 PST 
Comment on attachment 224461 [details]
Same as the last patch, but name the category

Clearing flags on attachment: 224461

Committed r164272: <http://trac.webkit.org/changeset/164272>