Bug 128842 - Margin tiles are not created for top and left sides when there is a < 1.0 scale factor
Summary: Margin tiles are not created for top and left sides when there is a < 1.0 sca...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-14 14:01 PST by Beth Dakin
Modified: 2014-02-14 14:27 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.76 KB, patch)
2014-02-14 14:13 PST, Beth Dakin 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2014-02-14 14:01:03 PST 
The TileController is failing to create margin tiles for the top and left sides when the there a scaled factor on the TileController that is less the 1.0.
Comment 1 Beth Dakin 2014-02-14 14:13:43 PST 
Created attachment 224252 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-02-14 14:17:33 PST 
Comment on attachment 224252 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224252&action=review

> Source/WebCore/platform/graphics/ca/mac/TileController.mm:474
> +        topLeft.setX(floor((float)clampedRect.x() / leftMarginWidth()));

floorf?

> Source/WebCore/platform/graphics/ca/mac/TileController.mm:479
> +        topLeft.setY(floor((float)clampedRect.y() / topMarginHeight()));

Ditto.
Comment 3 Beth Dakin 2014-02-14 14:27:25 PST 
floorf'd! Fixed with r164135