Bug 12883 - Disable experimental SVG features
Summary: Disable experimental SVG features
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 523.x (Safari 3)
Hardware: All OS X 10.4
: P1 Normal
Assignee: Maciej Stachowiak
Keywords: InRadar
Depends on:
Reported: 2007-02-24 17:35 PST by Maciej Stachowiak
Modified: 2007-02-26 11:51 PST (History)
1 user (show)

See Also:

patch to add ENABLE_SVG_EXPERIMENTAL_FEATURES define (368.42 KB, patch)
2007-02-26 05:41 PST, Maciej Stachowiak
lars.knoll: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2007-02-24 17:35:50 PST
As part of the current WebKit stabilization effort, we'd like to disable some of the more experimental SVG features, including:

- SVG in images
- Animation
- Filters
- <use>
- <foreignObject>

I would suggest adding a single define SVG_ENABLE_EXPERIMENTAL_FEATURES, to guard them all, so it is still possible to test them for those who want to.
Comment 1 Maciej Stachowiak 2007-02-24 19:10:26 PST
Comment 2 Maciej Stachowiak 2007-02-24 19:17:29 PST
Once this is resolved, bugs with these features will no longer be P1.
Comment 3 Kyle Rove 2007-02-25 07:10:10 PST
How experimental is <use> support? A number of SVGs use it and it would be a shame to have it miss the boat.
Comment 4 Antoine Quint 2007-02-25 09:55:26 PST
Nikolas's assesment of the situation when it comes to <use> in http://lists.macosforge.org/pipermail/webkit-dev/2007-February/001683.html leads me to think that <use> is quite testable and supported well enough to make the cut as a stable feature. Given the high value of this feature and how widely used it is in SVG content out there, I sincerely hope it's not marked as experimental. 
Comment 5 Maciej Stachowiak 2007-02-26 05:35:35 PST
My plan is to disable <use> for now with the other bleeding-edge features. If someone wants to do extra testing for it, we can reconsider and flip the switch back at some point.
Comment 6 Maciej Stachowiak 2007-02-26 05:41:15 PST
Created attachment 13378 [details]

This patch doesn't include the changes to numerous SVG test cases that result from it, I would land those with the patch. However, we may want a buildbot with experimental features on so these don't stop getting regression testing.
Comment 7 Maciej Stachowiak 2007-02-26 05:42:11 PST
The patch also reworks how optional features in general are handled, so now the code says things like:


instead of:

Comment 8 Lars Knoll 2007-02-26 08:03:09 PST
Comment on attachment 13378 [details]

-    print "#ifdef SVG_SUPPORT\n";
+    print "#if EABLE(SVG)\n";

should be ENABLE.

The SVG filters in platform/graphics/svg should not get compiled in.

With these two changes it's r=me.
Comment 9 Maciej Stachowiak 2007-02-26 11:51:32 PST
Landed (adjusted for some of Lars's comments).