Bug 128821 - [CSS Shapes] Add performance test for stacked floats with shape-outsides
Summary: [CSS Shapes] Add performance test for stacked floats with shape-outsides
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords:
Depends on:
Blocks: 128188
  Show dependency tree / graph
 
Reported: 2014-02-14 09:34 PST by Zoltan Horvath
Modified: 2014-02-19 15:17 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.60 KB, patch)
2014-02-18 13:48 PST, Zoltan Horvath 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2014-02-14 09:34:37 PST 
Add performance test for stacked floats with shape-outsides.
Comment 1 Zoltan Horvath 2014-02-18 13:48:08 PST 
Created attachment 224540 [details]
Patch
Comment 2 Brent Fulgham 2014-02-19 11:29:32 PST 
Comment on attachment 224540 [details]
Patch

r=me. When do you plan on turning this on?
Comment 3 Zoltan Horvath 2014-02-19 14:42:28 PST 
(In reply to comment #2)
> (From update of attachment 224540 [details])
> r=me. When do you plan on turning this on?

I'm going to come up with an integrated shapes+regions test soon. 
These tests are micro benchmarks, good for verify the performance impact for our code changes. As per my discussion with Ryosuke, they would require too much time on the perf.tester bot, so we can't enable them by default.
I'm planning to set up an internal tester to run these continuously though.
Comment 4 WebKit Commit Bot 2014-02-19 15:17:30 PST 
Comment on attachment 224540 [details]
Patch

Clearing flags on attachment: 224540

Committed r164395: <http://trac.webkit.org/changeset/164395>
Comment 5 WebKit Commit Bot 2014-02-19 15:17:32 PST 
All reviewed patches have been landed.  Closing bug.