Bug 128814 - [CSS Regions] visibility: hidden on a region should hide its content
Summary: [CSS Regions] visibility: hidden on a region should hide its content
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andrei Bucur
URL:
Keywords: AdobeTracked
Depends on:
Blocks: 57312
  Show dependency treegraph
 
Reported: 2014-02-14 07:05 PST by Andrei Bucur
Modified: 2014-02-14 09:30 PST (History)
6 users (show)

See Also:


Attachments
Test case (793 bytes, text/html)
2014-02-14 07:05 PST, Andrei Bucur
no flags Details
Patch (4.40 KB, patch)
2014-02-14 08:15 PST, Andrei Bucur
no flags Details | Formatted Diff | Diff
Patch (4.17 KB, patch)
2014-02-14 08:44 PST, Andrei Bucur
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Bucur 2014-02-14 07:05:02 PST
Created attachment 224211 [details]
Test case

See the attached test case.
Comment 1 Andrei Bucur 2014-02-14 08:15:10 PST
Created attachment 224217 [details]
Patch
Comment 2 Mihnea Ovidenie 2014-02-14 08:39:05 PST
Comment on attachment 224217 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224217&action=review

> LayoutTests/fast/regions/visibility-hidden-expected.html:5
> +    <meta http-equiv="content-type" content="text/html; charset=UTF-8">

Please remove this meta tag.

> LayoutTests/fast/regions/visibility-hidden.html:5
> +    <meta http-equiv="content-type" content="text/html; charset=UTF-8">

Ditto.

> LayoutTests/fast/regions/visibility-hidden.html:11
> +        border: 1px solid red;

Do you need the region to have dimensions and border for this test?

> LayoutTests/fast/regions/visibility-hidden.html:16
> +        margin-top: 0px;

Why do you margin-top on this? I doubt that you need it.
Comment 3 Andrei Bucur 2014-02-14 08:44:31 PST
Created attachment 224219 [details]
Patch
Comment 4 Mihnea Ovidenie 2014-02-14 08:47:57 PST
Comment on attachment 224219 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2014-02-14 09:30:15 PST
Comment on attachment 224219 [details]
Patch

Clearing flags on attachment: 224219

Committed r164103: <http://trac.webkit.org/changeset/164103>
Comment 6 WebKit Commit Bot 2014-02-14 09:30:17 PST
All reviewed patches have been landed.  Closing bug.