Bug 128804 – setSelectionRange shouldn't trigger a synchronous layout to check focusability when text field is already focused

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Ryosuke Niwa]

HTMLTextFormControl::setSelectionRange doesn't need to trigger a synchronous layout
if the text field is already focused since we don't need to call hasVisibleTextArea in that case,
which depends on the dimension of RenderBox.

[Ryosuke Niwa]

We can get rid of synchronous layout completely once we fix webkit.org/b/38696 as I've outlined in
https://lists.webkit.org/pipermail/webkit-dev/2014-February/026235.html

but we can fix this one first in order to resolve the bug 128797 since we don't call setSelectionRange in setValue when the text field is not focused.

[Ryosuke Niwa]

Created attachment 224186 [details]
Fixes the bug

[WebKit Commit Bot]

Attachment 224186 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:19:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Ryosuke Niwa]

Comment on attachment 224186 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=224186&action=review

> Source/WebCore/ChangeLog:19
> +	already. Also pass in DoNotSetFocus option to setSelection since we already have the focus in that case.

Odd. I thought I removed this tab character before uploading it :/

[Enrica Casucci]

Comment on attachment 224186 [details]
Fixes the bug

Looks good.

[Ryosuke Niwa]

Committed r164156: <http://trac.webkit.org/changeset/164156>