Bug 128799 - [GTK] MEDIA_CONTROLS_SCRIPT depends on VIDEO_TRACK
Summary: [GTK] MEDIA_CONTROLS_SCRIPT depends on VIDEO_TRACK
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: ChangSeok Oh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-13 23:51 PST by ChangSeok Oh
Modified: 2014-02-17 08:13 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.40 KB, patch)
2014-02-14 00:52 PST, ChangSeok Oh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ChangSeok Oh 2014-02-13 23:51:13 PST 
MEDIA_CONTROLS_SCRIPT has a dependency on VIDEO_TRACK. So it causes a build break if building with autotools.
cmake system has enabled it as default. So I propose enabling VIDEO_TRACK as well


 CXX      DerivedSources/WebCore/libWebCore_la-JSMediaTrackConstraint.lo
  CXX      DerivedSources/WebCore/libWebCore_la-JSMessageChannel.lo
  CXX      DerivedSources/WebCore/libWebCore_la-JSMessageEvent.lo
  CXX      DerivedSources/WebCore/libWebCore_la-JSMessagePort.lo
DerivedSources/WebCore/JSMediaControlsHost.cpp: In function 'JSC::EncodedJSValue WebCore::jsMediaControlsHostCaptionMenuOffItem(JSC::ExecState*, JSC::JSObject*, JSC::EncodedJSValue, JSC::PropertyName)':
DerivedSources/WebCore/JSMediaControlsHost.cpp:121:99: error: no matching function for call to 'toJS(JSC::ExecState*&, WebCore::JSDOMGlobalObject*, WebCore::TextTrack*)'
     JSValue result = toJS(exec, castedThis->globalObject(), WTF::getPtr(impl.captionMenuOffItem()));
                                                                                                   ^
DerivedSources/WebCore/JSMediaControlsHost.cpp:121:99: note: candidates are:
In file included from DerivedSources/WebCore/JSMediaControlsHost.h:26:0,
                 from DerivedSources/WebCore/JSMediaControlsHost.cpp:25:
../../Source/WebCore/bindings/js/JSDOMBinding.h:350:21: note: JSC::JSValue WebCore::toJS(JSC::ExecState*, WebCore::JSDOMGlobalObject*, JSC::ArrayBuffer*)
 inline JSC::JSValue toJS(JSC::ExecState* exec, JSDOMGlobalObject* globalObject, JSC::ArrayBuffer* buffer)
                     ^
../../Source/WebCore/bindings/js/JSDOMBinding.h:350:21: note:   no known conversion for argument 3 from 'WebCore::TextTrack*' to 'JSC::ArrayBuffer*'
../../Source/WebCore/bindings/js/JSDOMBinding.h:362:21: note: JSC::JSValue WebCore::toJS(JSC::ExecState*, WebCore::JSDOMGlobalObject*, JSC::ArrayBufferView*)
 inline JSC::JSValue toJS(JSC::ExecState* exec, JSDOMGlobalObject* globalObject, JSC::ArrayBufferView* view)
                     ^
../../Source/WebCore/bindings/js/JSDOMBinding.h:362:21: note:   no known conversion for argument 3 from 'WebCore::TextTrack*' to 'JSC::ArrayBufferView*'
../../Source/WebCore/bindings/js/JSDOMBinding.h:370:21: note: template<class T> JSC::JSValue WebCore::toJS(JSC::ExecState*, WebCore::JSDOMGlobalObject*, WTF::PassRefPtr<T>)
 inline JSC::JSValue toJS(JSC::ExecState* exec, JSDOMGlobalObject* globalObject, PassRefPtr<T> ptr)
                     ^
../../Source/WebCore/bindings/js/JSDOMBinding.h:370:21: note:   template argument deduction/substitution failed:
DerivedSources/WebCore/JSMediaControlsHost.cpp:121:99: note:   mismatched types 'WTF::PassRefPtr<T>' and 'WebCore::TextTrack*'
     JSValue result = toJS(exec, castedThis->globalObject(), WTF::getPtr(impl.captionMenuOffItem()));
                                                                                                   ^
In file included from DerivedSources/WebCore/JSMediaControlsHost.h:26:0,
                 from DerivedSources/WebCore/JSMediaControlsHost.cpp:25:
../../Source/WebCore/bindings/js/JSDOMBinding.h:376:21: note: template<class T> JSC::JSValue WebCore::toJS(JSC::ExecState*, WebCore::JSDOMGlobalObject*, const WTF::Vector<CharacterType>&)
 inline JSC::JSValue toJS(JSC::ExecState* exec, JSDOMGlobalObject* globalObject, const Vector<T>& vector)
                     ^
../../Source/WebCore/bindings/js/JSDOMBinding.h:376:21: note:   template argument deduction/substitution failed:
DerivedSources/WebCore/JSMediaControlsHost.cpp:121:99: note:   mismatched types 'const WTF::Vector<CharacterType>' and 'WebCore::TextTrack*'
     JSValue result = toJS(exec, castedThis->globalObject(), WTF::getPtr(impl.captionMenuOffItem()));
                                                                                                   ^
In file included from DerivedSources/WebCore/JSMediaControlsHost.h:26:0,
                 from DerivedSources/WebCore/JSMediaControlsHost.cpp:25:
../../Source/WebCore/bindings/js/JSDOMBinding.h:387:21: note: template<class T> JSC::JSValue WebCore::toJS(JSC::ExecState*, WebCore::JSDOMGlobalObject*, const WTF::Vector<WTF::RefPtr<T> >&)
 inline JSC::JSValue toJS(JSC::ExecState* exec, JSDOMGlobalObject* globalObject, const Vector<RefPtr<T>>& vector)
                     ^
../../Source/WebCore/bindings/js/JSDOMBinding.h:387:21: note:   template argument deduction/substitution failed:
DerivedSources/WebCore/JSMediaControlsHost.cpp:121:99: note:   mismatched types 'const WTF::Vector<WTF::RefPtr<T> >' and 'WebCore::TextTrack*'
     JSValue result = toJS(exec, castedThis->globalObject(), WTF::getPtr(impl.captionMenuOffItem()));
                                                                                                   ^
In file included from DerivedSources/WebCore/JSMediaControlsHost.h:26:0,
                 from DerivedSources/WebCore/JSMediaControlsHost.cpp:25:
../../Source/WebCore/bindings/js/JSDOMBinding.h:397:21: note: JSC::JSValue WebCore::toJS(JSC::ExecState*, WebCore::JSDOMGlobalObject*, const WTF::String&)
 inline JSC::JSValue toJS(JSC::ExecState* exec, JSDOMGlobalObject*, const String& value)
                     ^
../../Source/WebCore/bindings/js/JSDOMBinding.h:397:21: note:   no known conversion for argument 3 from 'WebCore::TextTrack*' to 'const WTF::String&'
In file included from DerivedSources/WebCore/JSMediaControlsHost.cpp:25:0:
DerivedSources/WebCore/JSMediaControlsHost.h:90:14: note: JSC::JSValue WebCore::toJS(JSC::ExecState*, WebCore::JSDOMGlobalObject*, WebCore::MediaControlsHost*)
 JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, MediaControlsHost*);
              ^
DerivedSources/WebCore/JSMediaControlsHost.h:90:14: note:   no known conversion for argument 3 from 'WebCore::TextTrack*' to 'WebCore::MediaControlsHost*'
In file included from DerivedSources/WebCore/JSNode.h:219:0,
                 from DerivedSources/WebCore/JSElement.h:26,
                 from DerivedSources/WebCore/JSHTMLElement.h:26,
                 from DerivedSources/WebCore/JSMediaControlsHost.cpp:30:
../../Source/WebCore/bindings/js/JSNodeCustom.h:38:25: note: JSC::JSValue WebCore::toJS(JSC::ExecState*, WebCore::JSDOMGlobalObject*, WebCore::Node*)
 inline JSC::JSValue toJS(JSC::ExecState* exec, JSDOMGlobalObject* globalObject, Node* node)
                         ^
../../Source/WebCore/bindings/js/JSNodeCustom.h:38:25: note:   no known conversion for argument 3 from 'WebCore::TextTrack*' to 'WebCore::Node*'
DerivedSources/WebCore/JSMediaControlsHost.cpp: In function 'JSC::EncodedJSValue WebCore::jsMediaControlsHostCaptionMenuAutomaticItem(JSC::ExecState*, JSC::JSObject*, JSC::EncodedJSValue, JSC::PropertyName)':
DerivedSources/WebCore/JSMediaControlsHost.cpp:140:105: error: no matching function for call to 'toJS(JSC::ExecState*&, WebCore::JSDOMGlobalObject*, WebCore::TextTrack*)'
     JSValue result = toJS(exec, castedThis->globalObject(), WTF::getPtr(impl.captionMenuAutomaticItem()));
                                                                                                         ^
DerivedSources/WebCore/JSMediaControlsHost.cpp:140:105: note: candidates are:
In file included from DerivedSources/WebCore/JSMediaControlsHost.h:26:0,
                 from DerivedSources/WebCore/JSMediaControlsHost.cpp:25:
../../Source/WebCore/bindings/js/JSDOMBinding.h:350:21: note: JSC::JSValue WebCore::toJS(JSC::ExecState*, WebCore::JSDOMGlobalObject*, JSC::ArrayBuffer*)
 inline JSC::JSValue toJS(JSC::ExecState* exec, JSDOMGlobalObject* globalObject, JSC::ArrayBuffer* buffer)
                     ^
../../Source/WebCore/bindings/js/JSDOMBinding.h:350:21: note:   no known conversion for argument 3 from 'WebCore::TextTrack*' to 'JSC::ArrayBuffer*'
../../Source/WebCore/bindings/js/JSDOMBinding.h:362:21: note: JSC::JSValue WebCore::toJS(JSC::ExecState*, WebCore::JSDOMGlobalObject*, JSC::ArrayBufferView*)
 inline JSC::JSValue toJS(JSC::ExecState* exec, JSDOMGlobalObject* globalObject, JSC::ArrayBufferView* view)
                     ^
../../Source/WebCore/bindings/js/JSDOMBinding.h:362:21: note:   no known conversion for argument 3 from 'WebCore::TextTrack*' to 'JSC::ArrayBufferView*'
../../Source/WebCore/bindings/js/JSDOMBinding.h:370:21: note: template<class T> JSC::JSValue WebCore::toJS(JSC::ExecState*, WebCore::JSDOMGlobalObject*, WTF::PassRefPtr<T>)
 inline JSC::JSValue toJS(JSC::ExecState* exec, JSDOMGlobalObject* globalObject, PassRefPtr<T> ptr)
                     ^
../../Source/WebCore/bindings/js/JSDOMBinding.h:370:21: note:   template argument deduction/substitution failed:
DerivedSources/WebCore/JSMediaControlsHost.cpp:140:105: note:   mismatched types 'WTF::PassRefPtr<T>' and 'WebCore::TextTrack*'
     JSValue result = toJS(exec, castedThis->globalObject(), WTF::getPtr(impl.captionMenuAutomaticItem()));
                                                                                                         ^
In file included from DerivedSources/WebCore/JSMediaControlsHost.h:26:0,
                 from DerivedSources/WebCore/JSMediaControlsHost.cpp:25:
../../Source/WebCore/bindings/js/JSDOMBinding.h:376:21: note: template<class T> JSC::JSValue WebCore::toJS(JSC::ExecState*, WebCore::JSDOMGlobalObject*, const WTF::Vector<CharacterType>&)
 inline JSC::JSValue toJS(JSC::ExecState* exec, JSDOMGlobalObject* globalObject, const Vector<T>& vector)
                     ^
../../Source/WebCore/bindings/js/JSDOMBinding.h:376:21: note:   template argument deduction/substitution failed:
DerivedSources/WebCore/JSMediaControlsHost.cpp:140:105: note:   mismatched types 'const WTF::Vector<CharacterType>' and 'WebCore::TextTrack*'
     JSValue result = toJS(exec, castedThis->globalObject(), WTF::getPtr(impl.captionMenuAutomaticItem()));
                                                                                                         ^
In file included from DerivedSources/WebCore/JSMediaControlsHost.h:26:0,
                 from DerivedSources/WebCore/JSMediaControlsHost.cpp:25:
../../Source/WebCore/bindings/js/JSDOMBinding.h:387:21: note: template<class T> JSC::JSValue WebCore::toJS(JSC::ExecState*, WebCore::JSDOMGlobalObject*, const WTF::Vector<WTF::RefPtr<T> >&)
 inline JSC::JSValue toJS(JSC::ExecState* exec, JSDOMGlobalObject* globalObject, const Vector<RefPtr<T>>& vector)
                     ^
../../Source/WebCore/bindings/js/JSDOMBinding.h:387:21: note:   template argument deduction/substitution failed:
DerivedSources/WebCore/JSMediaControlsHost.cpp:140:105: note:   mismatched types 'const WTF::Vector<WTF::RefPtr<T> >' and 'WebCore::TextTrack*'
     JSValue result = toJS(exec, castedThis->globalObject(), WTF::getPtr(impl.captionMenuAutomaticItem()));
                                                                                                         ^
In file included from DerivedSources/WebCore/JSMediaControlsHost.h:26:0,
                 from DerivedSources/WebCore/JSMediaControlsHost.cpp:25:
../../Source/WebCore/bindings/js/JSDOMBinding.h:397:21: note: JSC::JSValue WebCore::toJS(JSC::ExecState*, WebCore::JSDOMGlobalObject*, const WTF::String&)
 inline JSC::JSValue toJS(JSC::ExecState* exec, JSDOMGlobalObject*, const String& value)
                     ^
../../Source/WebCore/bindings/js/JSDOMBinding.h:397:21: note:   no known conversion for argument 3 from 'WebCore::TextTrack*' to 'const WTF::String&'
In file included from DerivedSources/WebCore/JSMediaControlsHost.cpp:25:0:
DerivedSources/WebCore/JSMediaControlsHost.h:90:14: note: JSC::JSValue WebCore::toJS(JSC::ExecState*, WebCore::JSDOMGlobalObject*, WebCore::MediaControlsHost*)
 JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, MediaControlsHost*);
              ^
DerivedSources/WebCore/JSMediaControlsHost.h:90:14: note:   no known conversion for argument 3 from 'WebCore::TextTrack*' to 'WebCore::MediaControlsHost*'
In file included from DerivedSources/WebCore/JSNode.h:219:0,
                 from DerivedSources/WebCore/JSElement.h:26,
                 from DerivedSources/WebCore/JSHTMLElement.h:26,
                 from DerivedSources/WebCore/JSMediaControlsHost.cpp:30:
../../Source/WebCore/bindings/js/JSNodeCustom.h:38:25: note: JSC::JSValue WebCore::toJS(JSC::ExecState*, WebCore::JSDOMGlobalObject*, WebCore::Node*)
 inline JSC::JSValue toJS(JSC::ExecState* exec, JSDOMGlobalObject* globalObject, Node* node)
                         ^
../../Source/WebCore/bindings/js/JSNodeCustom.h:38:25: note:   no known conversion for argument 3 from 'WebCore::TextTrack*' to 'WebCore::Node*'
DerivedSources/WebCore/JSMediaControlsHost.cpp: In function 'JSC::EncodedJSValue WebCore::jsMediaControlsHostPrototypeFunctionSortedTrackListForMenu(JSC::ExecState*)':
DerivedSources/WebCore/JSMediaControlsHost.cpp:231:63: error: 'toTextTrackList' was not declared in this scope
     TextTrackList* trackList(toTextTrackList(exec->argument(0)));
                                                               ^
DerivedSources/WebCore/JSMediaControlsHost.cpp: In function 'JSC::EncodedJSValue WebCore::jsMediaControlsHostPrototypeFunctionDisplayNameForTrack(JSC::ExecState*)':
DerivedSources/WebCore/JSMediaControlsHost.cpp:249:51: error: 'toTextTrack' was not declared in this scope
     TextTrack* track(toTextTrack(exec->argument(0)));
                                                   ^
DerivedSources/WebCore/JSMediaControlsHost.cpp: In function 'JSC::EncodedJSValue WebCore::jsMediaControlsHostPrototypeFunctionSetSelectedTextTrack(JSC::ExecState*)':
DerivedSources/WebCore/JSMediaControlsHost.cpp:267:51: error: 'toTextTrack' was not declared in this scope
     TextTrack* track(toTextTrack(exec->argument(0)));
                                                   ^
In file included from DerivedSources/WebCore/JSMediaControlsHost.h:26:0,
                 from DerivedSources/WebCore/JSMediaControlsHost.cpp:25:
../../Source/WebCore/bindings/js/JSDOMBinding.h: In instantiation of 'static JSC::JSValue WebCore::JSValueTraits<T>::arrayJSValue(JSC::ExecState*, WebCore::JSDOMGlobalObject*, const T&) [with T = WTF::RefPtr<WebCore::TextTrack>]':
../../Source/WebCore/bindings/js/JSDOMBinding.h:442:71:   required from 'JSC::JSValue WebCore::jsArray(JSC::ExecState*, WebCore::JSDOMGlobalObject*, const WTF::Vector<U, otherCapacity, WTF::CrashOnOverflow>&) [with T = WTF::RefPtr<WebCore::TextTrack>; long unsigned int inlineCapacity = 0ul]'
DerivedSources/WebCore/JSMediaControlsHost.cpp:235:107:   required from here
../../Source/WebCore/bindings/js/JSDOMBinding.h:406:59: error: no matching function for call to 'toJS(JSC::ExecState*&, WebCore::JSDOMGlobalObject*&, WebCore::TextTrack*)'
         return toJS(exec, globalObject, WTF::getPtr(value));
                                                           ^
../../Source/WebCore/bindings/js/JSDOMBinding.h:406:59: note: candidates are:
../../Source/WebCore/bindings/js/JSDOMBinding.h:350:21: note: JSC::JSValue WebCore::toJS(JSC::ExecState*, WebCore::JSDOMGlobalObject*, JSC::ArrayBuffer*)
 inline JSC::JSValue toJS(JSC::ExecState* exec, JSDOMGlobalObject* globalObject, JSC::ArrayBuffer* buffer)
                     ^
../../Source/WebCore/bindings/js/JSDOMBinding.h:350:21: note:   no known conversion for argument 3 from 'WebCore::TextTrack*' to 'JSC::ArrayBuffer*'
../../Source/WebCore/bindings/js/JSDOMBinding.h:362:21: note: JSC::JSValue WebCore::toJS(JSC::ExecState*, WebCore::JSDOMGlobalObject*, JSC::ArrayBufferView*)
 inline JSC::JSValue toJS(JSC::ExecState* exec, JSDOMGlobalObject* globalObject, JSC::ArrayBufferView* view)
                     ^
../../Source/WebCore/bindings/js/JSDOMBinding.h:362:21: note:   no known conversion for argument 3 from 'WebCore::TextTrack*' to 'JSC::ArrayBufferView*'
../../Source/WebCore/bindings/js/JSDOMBinding.h:370:21: note: template<class T> JSC::JSValue WebCore::toJS(JSC::ExecState*, WebCore::JSDOMGlobalObject*, WTF::PassRefPtr<T>)
 inline JSC::JSValue toJS(JSC::ExecState* exec, JSDOMGlobalObject* globalObject, PassRefPtr<T> ptr)
                     ^
../../Source/WebCore/bindings/js/JSDOMBinding.h:370:21: note:   template argument deduction/substitution failed:
../../Source/WebCore/bindings/js/JSDOMBinding.h:406:59: note:   mismatched types 'WTF::PassRefPtr<T>' and 'WebCore::TextTrack*'
         return toJS(exec, globalObject, WTF::getPtr(value));
                                                           ^
../../Source/WebCore/bindings/js/JSDOMBinding.h:376:21: note: template<class T> JSC::JSValue WebCore::toJS(JSC::ExecState*, WebCore::JSDOMGlobalObject*, const WTF::Vector<CharacterType>&)
 inline JSC::JSValue toJS(JSC::ExecState* exec, JSDOMGlobalObject* globalObject, const Vector<T>& vector)
                     ^
../../Source/WebCore/bindings/js/JSDOMBinding.h:376:21: note:   template argument deduction/substitution failed:
../../Source/WebCore/bindings/js/JSDOMBinding.h:406:59: note:   mismatched types 'const WTF::Vector<CharacterType>' and 'WebCore::TextTrack*'
         return toJS(exec, globalObject, WTF::getPtr(value));
                                                           ^
../../Source/WebCore/bindings/js/JSDOMBinding.h:387:21: note: template<class T> JSC::JSValue WebCore::toJS(JSC::ExecState*, WebCore::JSDOMGlobalObject*, const WTF::Vector<WTF::RefPtr<T> >&)
 inline JSC::JSValue toJS(JSC::ExecState* exec, JSDOMGlobalObject* globalObject, const Vector<RefPtr<T>>& vector)
                     ^
../../Source/WebCore/bindings/js/JSDOMBinding.h:387:21: note:   template argument deduction/substitution failed:
../../Source/WebCore/bindings/js/JSDOMBinding.h:406:59: note:   mismatched types 'const WTF::Vector<WTF::RefPtr<T> >' and 'WebCore::TextTrack*'
         return toJS(exec, globalObject, WTF::getPtr(value));
                                                           ^
../../Source/WebCore/bindings/js/JSDOMBinding.h:397:21: note: JSC::JSValue WebCore::toJS(JSC::ExecState*, WebCore::JSDOMGlobalObject*, const WTF::String&)
 inline JSC::JSValue toJS(JSC::ExecState* exec, JSDOMGlobalObject*, const String& value)
                     ^
../../Source/WebCore/bindings/js/JSDOMBinding.h:397:21: note:   no known conversion for argument 3 from 'WebCore::TextTrack*' to 'const WTF::String&'
In file included from DerivedSources/WebCore/JSNode.h:219:0,
                 from DerivedSources/WebCore/JSElement.h:26,
                 from DerivedSources/WebCore/JSHTMLElement.h:26,
                 from DerivedSources/WebCore/JSMediaControlsHost.cpp:30:
../../Source/WebCore/bindings/js/JSNodeCustom.h:38:25: note: JSC::JSValue WebCore::toJS(JSC::ExecState*, WebCore::JSDOMGlobalObject*, WebCore::Node*)
 inline JSC::JSValue toJS(JSC::ExecState* exec, JSDOMGlobalObject* globalObject, Node* node)
                         ^
../../Source/WebCore/bindings/js/JSNodeCustom.h:38:25: note:   no known conversion for argument 3 from 'WebCore::TextTrack*' to 'WebCore::Node*'
DerivedSources/WebCore/JSMediaControlsHost.cpp:301:14: note: JSC::JSValue WebCore::toJS(JSC::ExecState*, WebCore::JSDOMGlobalObject*, WebCore::MediaControlsHost*)
 JSC::JSValue toJS(JSC::ExecState* exec, JSDOMGlobalObject* globalObject, MediaControlsHost* impl)
              ^
DerivedSources/WebCore/JSMediaControlsHost.cpp:301:14: note:   no known conversion for argument 3 from 'WebCore::TextTrack*' to 'WebCore::MediaControlsHost*'
In file included from ../../Source/WTF/wtf/RefPtr.h:27:0,
                 from ../../Source/WTF/wtf/MetaAllocatorHandle.h:35,
                 from ../../Source/JavaScriptCore/jit/ExecutableAllocator.h:32,
                 from ../../Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h:30,
                 from ../../Source/JavaScriptCore/interpreter/AbstractPC.h:29,
                 from ../../Source/JavaScriptCore/interpreter/CallFrame.h:26,
                 from ../../Source/JavaScriptCore/interpreter/CallFrameInlines.h:29,
                 from ../../Source/JavaScriptCore/runtime/JSCInlines.h:40,
                 from ../../Source/WebCore/bindings/js/JSDOMGlobalObject.h:31,
                 from ../../Source/WebCore/bindings/js/JSDOMBinding.h:27,
                 from DerivedSources/WebCore/JSMediaControlsHost.h:26,
                 from DerivedSources/WebCore/JSMediaControlsHost.cpp:25:
../../Source/WTF/wtf/PassRefPtr.h: In instantiation of 'void WTF::derefIfNotNull(T*) [with T = WebCore::TextTrack]':
../../Source/WTF/wtf/RefPtr.h:55:83:   required from 'WTF::RefPtr<T>::~RefPtr() [with T = WebCore::TextTrack]'
../../Source/WTF/wtf/Vector.h:57:13:   required from 'static void WTF::VectorDestructor<true, T>::destruct(T*, T*) [with T = WTF::RefPtr<WebCore::TextTrack>]'
../../Source/WTF/wtf/Vector.h:215:92:   required from 'static void WTF::VectorTypeOperations<T>::destruct(T*, T*) [with T = WTF::RefPtr<WebCore::TextTrack>]'
../../Source/WTF/wtf/Vector.h:926:51:   required from 'void WTF::Vector<T, inlineCapacity, OverflowHandler>::shrink(size_t) [with T = WTF::RefPtr<WebCore::TextTrack>; long unsigned int inlineCapacity = 0ul; OverflowHandler = WTF::CrashOnOverflow; size_t = long unsigned int]'
../../Source/WTF/wtf/Vector.h:565:21:   required from 'WTF::Vector<T, inlineCapacity, OverflowHandler>::~Vector() [with T = WTF::RefPtr<WebCore::TextTrack>; long unsigned int inlineCapacity = 0ul; OverflowHandler = WTF::CrashOnOverflow]'
DerivedSources/WebCore/JSMediaControlsHost.cpp:235:106:   required from here
../../Source/WTF/wtf/PassRefPtr.h:39:13: error: invalid use of incomplete type 'class WebCore::TextTrack'
             ptr->deref();
             ^
In file included from DerivedSources/WebCore/JSMediaControlsHost.h:27:0,
                 from DerivedSources/WebCore/JSMediaControlsHost.cpp:25:
../../Source/WebCore/Modules/mediacontrols/MediaControlsHost.h:41:7: error: forward declaration of 'class WebCore::TextTrack'
 class TextTrack;
       ^
In file included from DerivedSources/WebCore/JSMediaControlsHost.h:26:0,
                 from DerivedSources/WebCore/JSMediaControlsHost.cpp:25:
../../Source/WebCore/bindings/js/JSDOMBinding.h: In static member function 'static JSC::JSValue WebCore::JSValueTraits<T>::arrayJSValue(JSC::ExecState*, WebCore::JSDOMGlobalObject*, const T&) [with T = WTF::RefPtr<WebCore::TextTrack>]':
../../Source/WebCore/bindings/js/JSDOMBinding.h:407:5: warning: control reaches end of non-void function [-Wreturn-type]
     }
     ^
make[1]: *** [DerivedSources/WebCore/libWebCore_la-JSMediaControlsHost.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/home/shivamidow/Projects/WebKit/WebKitBuild/Release'
make: *** [all] Error 2
Comment 1 ChangSeok Oh 2014-02-14 00:52:45 PST 
Created attachment 224175 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2014-02-14 03:09:34 PST 
Comment on attachment 224175 [details]
Patch

I makes sense to me, but I guess Phil can be more helpful
Comment 3 WebKit Commit Bot 2014-02-17 08:13:02 PST 
Comment on attachment 224175 [details]
Patch

Clearing flags on attachment: 224175

Committed r164222: <http://trac.webkit.org/changeset/164222>
Comment 4 WebKit Commit Bot 2014-02-17 08:13:04 PST 
All reviewed patches have been landed.  Closing bug.