Bug 128798 - Use CXX instead of CC for preprocessor
Summary: Use CXX instead of CC for preprocessor
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-13 23:06 PST by Ting-Wei Lan
Modified: 2014-11-29 10:53 PST (History)
6 users (show)

See Also:


Attachments
Replace CC with CXX (2.54 KB, patch)
2014-02-13 23:08 PST, Ting-Wei Lan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ting-Wei Lan 2014-02-13 23:06:38 PST
In Source/WebCore/bindings/scripts/preprocessor.pm and Source/WebCore/dom/make_names.pl, we use -x c++ to make sure the C preprocessor is running in C++ mode. This cause problem if the user set CC with options which is not available in C++, such as "clang -std=c11". We should use CXX instead for preprocessor, so -x c++ will not cause problem.
Comment 1 Ting-Wei Lan 2014-02-13 23:08:49 PST
Created attachment 224165 [details]
Replace CC with CXX
Comment 2 Zan Dobersek 2014-02-16 02:41:31 PST
Compiler flags should be placed into CFLAGS and CXXFLAGS environment variables.
Comment 3 Ting-Wei Lan 2014-02-24 22:25:58 PST
We shuold not assume the C compiler is the same as the C++ compiler.