Bug 128765 - Use AtomicString arguments in TrackPrivateBaseClient callbacks
Summary: Use AtomicString arguments in TrackPrivateBaseClient callbacks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brendan Long
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-13 14:09 PST by Brendan Long
Modified: 2014-02-14 09:46 PST (History)
8 users (show)

See Also:

Attachments
Patch (9.33 KB, patch)
2014-02-13 14:10 PST, Brendan Long 		no flags Details | Formatted Diff | Diff
Patch (9.32 KB, patch)
2014-02-13 15:09 PST, Brendan Long 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brendan Long 2014-02-13 14:09:33 PST 
Use AtomicString arguments in TrackPrivateBaseClient callbacks
Comment 1 Brendan Long 2014-02-13 14:10:37 PST 
Created attachment 224108 [details]
Patch
Comment 2 Brendan Long 2014-02-13 14:12:27 PST 
I noticed this while I was writing another patch. id(), label(), language(), m_id, m_label, and m_language in all of the relevant functions are AtomicStrings, but for some reason these callbacks use normal Strings. I thought I read somewhere that converting between String and AtomicString is expensive and should be avoided.
Comment 3 Eric Carlson 2014-02-13 14:26:53 PST 
Comment on attachment 224108 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224108&action=review

> Source/WebCore/html/track/InbandTextTrack.cpp:61
> +    : TextTrack(context, client, AtomicString(), trackPrivate->id(), trackPrivate->label(), trackPrivate->language(), InBand)

emptyAtom please.
Comment 4 Brendan Long 2014-02-13 15:09:06 PST 
Created attachment 224116 [details]
Patch

Eclipse doesn't like me passing emptyAtom, but apparently it's valid so here we go.
Comment 5 WebKit Commit Bot 2014-02-14 09:46:21 PST 
Comment on attachment 224116 [details]
Patch

Clearing flags on attachment: 224116

Committed r164106: <http://trac.webkit.org/changeset/164106>
Comment 6 WebKit Commit Bot 2014-02-14 09:46:23 PST 
All reviewed patches have been landed.  Closing bug.