Use AtomicString arguments in TrackPrivateBaseClient callbacks
Created attachment 224108 [details]
I noticed this while I was writing another patch. id(), label(), language(), m_id, m_label, and m_language in all of the relevant functions are AtomicStrings, but for some reason these callbacks use normal Strings. I thought I read somewhere that converting between String and AtomicString is expensive and should be avoided.
Comment on attachment 224108 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=224108&action=review
> + : TextTrack(context, client, AtomicString(), trackPrivate->id(), trackPrivate->label(), trackPrivate->language(), InBand)
Created attachment 224116 [details]
Eclipse doesn't like me passing emptyAtom, but apparently it's valid so here we go.
Comment on attachment 224116 [details]
Clearing flags on attachment: 224116
Committed r164106: <http://trac.webkit.org/changeset/164106>
All reviewed patches have been landed. Closing bug.