WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
128753
Normalize some of the older JSC options
https://bugs.webkit.org/show_bug.cgi?id=128753
Summary
Normalize some of the older JSC options
Mark Hahnenberg
Reported
2014-02-13 12:04:03 PST
Some of the options manually look for non-standard environment variables (e.g. GCMaxHeapSize). We should get rid of these special cases.
Attachments
Patch
(1.51 KB, patch)
2014-03-12 11:34 PDT
,
Mark Hahnenberg
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1
2014-03-12 11:34:18 PDT
Created
attachment 226538
[details]
Patch
Michael Saboff
Comment 2
2014-03-12 12:44:12 PDT
Comment on
attachment 226538
[details]
Patch r=me You're actually deleted unused old options and note normalizing.
Mark Hahnenberg
Comment 3
2014-03-12 13:08:03 PDT
(In reply to
comment #2
)
> (From update of
attachment 226538
[details]
) > r=me > > You're actually deleted unused old options and note normalizing.
These were just non-standard names for other options which will continue to exist. E.g. JSC_recordGCPauseTimes and JSRecordGCPauseTimes were equivalent. We'll still have JSC_recordGCPauseTimes. Same for JSC_objectsAreImmortal, JSC_useZombieMode, JSC_gcMaxHeapSize, and JSC_logHeapStatisticsAtExit. I'm not removing the functionality of any of these options. So if we're being pedantic it really is a "standardization" or a "normalization" and not a "deletion".
WebKit Commit Bot
Comment 4
2014-03-19 12:33:11 PDT
Comment on
attachment 226538
[details]
Patch Clearing flags on attachment: 226538 Committed
r165909
: <
http://trac.webkit.org/changeset/165909
>
WebKit Commit Bot
Comment 5
2014-03-19 12:33:13 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug