Bug 128753 - Normalize some of the older JSC options
Summary: Normalize some of the older JSC options
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-13 12:04 PST by Mark Hahnenberg
Modified: 2014-03-19 12:33 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.51 KB, patch)
2014-03-12 11:34 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-02-13 12:04:03 PST 
Some of the options manually look for non-standard environment variables (e.g. GCMaxHeapSize). We should get rid of these special cases.
Comment 1 Mark Hahnenberg 2014-03-12 11:34:18 PDT 
Created attachment 226538 [details]
Patch
Comment 2 Michael Saboff 2014-03-12 12:44:12 PDT 
Comment on attachment 226538 [details]
Patch

r=me

You're actually deleted unused old options and note normalizing.
Comment 3 Mark Hahnenberg 2014-03-12 13:08:03 PDT 
(In reply to comment #2)
> (From update of attachment 226538 [details])
> r=me
> 
> You're actually deleted unused old options and note normalizing.

These were just non-standard names for other options which will continue to exist. E.g. JSC_recordGCPauseTimes and JSRecordGCPauseTimes were equivalent. We'll still have JSC_recordGCPauseTimes. Same for JSC_objectsAreImmortal, JSC_useZombieMode, JSC_gcMaxHeapSize, and JSC_logHeapStatisticsAtExit. I'm not removing the functionality of any of these options. So if we're being pedantic it really is a "standardization" or a "normalization" and not a "deletion".
Comment 4 WebKit Commit Bot 2014-03-19 12:33:11 PDT 
Comment on attachment 226538 [details]
Patch

Clearing flags on attachment: 226538

Committed r165909: <http://trac.webkit.org/changeset/165909>
Comment 5 WebKit Commit Bot 2014-03-19 12:33:13 PDT 
All reviewed patches have been landed.  Closing bug.