Bug 128752 - Add rendering progress events SPI
Summary: Add rendering progress events SPI
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
Depends on:
Reported: 2014-02-13 11:56 PST by Anders Carlsson
Modified: 2014-02-13 13:09 PST (History)
1 user (show)

See Also:

Patch (13.82 KB, patch)
2014-02-13 12:12 PST, Anders Carlsson
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-02-13 11:56:39 PST
Add rendering progress events SPI
Comment 1 Anders Carlsson 2014-02-13 12:12:21 PST
Created attachment 224092 [details]
Comment 2 WebKit Commit Bot 2014-02-13 12:15:08 PST
Attachment 224092 [details] did not pass style-queue:

ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:30:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:40:  Missing spaces around =  [whitespace/operators] [4]
Total errors found: 2 in 7 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 mitz 2014-02-13 13:06:44 PST
Comment on attachment 224092 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=224092&action=review

> Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:372
> +    [static_cast<id<WKNavigationDelegatePrivate>>(navigationDelegate.get()) _webView:m_navigationState.m_webView renderingProgressDidChange:renderingProgressEvents(layoutMilestones)];

Missing space after “id”
Comment 4 Anders Carlsson 2014-02-13 13:09:14 PST
Committed r164049: <http://trac.webkit.org/changeset/164049>