We have over 400 lines of attribute and parameterized attribute related defines at the top of WebAccessibilityObjectWrapperMac.mm (and growing). We should move these to a separate file and group/label them a bit better.
<rdar://problem/16060611>
Created attachment 366819 [details] Patch
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Attachment 366819 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 366820 [details] Patch
Attachment 366820 [details] did not pass style-queue: ERROR: LayoutTests/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] ERROR: LayoutTests/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] ERROR: LayoutTests/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] Total errors found: 3 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 366826 [details] Patch
Comment on attachment 366826 [details] Patch This patch has a lot of unrelated changes. Please submit another without them. Also, please give a rationale for why moving these lines is a good idea. The title of a bug typically needs to answer the question "why?" as well as just saying what’s changing.
Comment on attachment 366819 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366819&action=review > Source/WebCore/ChangeLog:10 > + * accessibility/mac/WebAccessibilityObjectWrapperMac.h: there's no need to put these #defines in a header that others import. they're only used inside this mm
Oh, I see, if this "bug" do not need to be fixed anymore can anybody please change its status to "CLOSED"? I started to work on it because I saw a status "NEW"