Bug 128747 - AX: Add ability to specify descendant type when using AXUIElementsForSearchPredicate.
Summary: AX: Add ability to specify descendant type when using AXUIElementsForSearchPr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac (Intel) OS X 10.9
: P2 Normal
Assignee: Samuel White
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-02-13 10:10 PST by Samuel White
Modified: 2014-02-15 00:28 PST (History)
16 users (show)

See Also:


Attachments
Patch for EWS. (27.67 KB, patch)
2014-02-13 11:53 PST, Samuel White
no flags Details | Formatted Diff | Diff
Patch for EWS. (30.76 KB, patch)
2014-02-13 12:04 PST, Samuel White
no flags Details | Formatted Diff | Diff
Patch for review. (38.08 KB, patch)
2014-02-13 12:48 PST, Samuel White
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (657.66 KB, application/zip)
2014-02-13 15:26 PST, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (633.48 KB, application/zip)
2014-02-13 15:40 PST, Build Bot
no flags Details
Patch. (38.28 KB, patch)
2014-02-13 16:43 PST, Samuel White
cfleizach: review+
Details | Formatted Diff | Diff
Rebased patch. (38.14 KB, patch)
2014-02-14 14:14 PST, Samuel White
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel White 2014-02-13 10:10:44 PST
Add the ability to limit element results to immediate container descendants only.

This can be accomplished by supporting the following new keys and values:

Key:
AXImmediateDescendantsOnly (similar to AXVisibleOnly)

Value:
YES/NO

Unless we suspect further descendant filtering needs will arise in the future. In which case we could start with:

Key:
AXSearchScope (similar to AXSearchText and AXSearchKey)

Values:
AXAllDescendants
AXImmediateDescendants
Comment 1 Radar WebKit Bug Importer 2014-02-13 10:11:16 PST
<rdar://problem/16060264>
Comment 2 Samuel White 2014-02-13 11:53:28 PST
Created attachment 224090 [details]
Patch for EWS.

Ignore this patch, just looking for platform failures at this point.
Comment 3 WebKit Commit Bot 2014-02-13 11:54:58 PST
Attachment 224090 [details] did not pass style-queue:


ERROR: Source/WebCore/accessibility/AccessibilityObject.h:352:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Samuel White 2014-02-13 12:04:47 PST
Created attachment 224091 [details]
Patch for EWS.

Fixing style and some build failures. Ignore.
Comment 5 Samuel White 2014-02-13 12:48:25 PST
Created attachment 224095 [details]
Patch for review.
Comment 6 Build Bot 2014-02-13 15:26:12 PST
Comment on attachment 224095 [details]
Patch for review.

Attachment 224095 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6367487323013120

New failing tests:
platform/mac/accessibility/search-predicate-immediate-descendants-only.html
Comment 7 Build Bot 2014-02-13 15:26:14 PST
Created attachment 224121 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 8 chris fleizach 2014-02-13 15:31:47 PST
Comment on attachment 224095 [details]
Patch for review.

View in context: https://bugs.webkit.org/attachment.cgi?id=224095&action=review

> Source/WebCore/ChangeLog:10
> +        Added support for 'immediate descendant only' to existing predicate based searching.

please add comment why we need this
Comment 9 Build Bot 2014-02-13 15:40:29 PST
Comment on attachment 224095 [details]
Patch for review.

Attachment 224095 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5257189958615040

New failing tests:
platform/mac/accessibility/search-predicate-immediate-descendants-only.html
Comment 10 Build Bot 2014-02-13 15:40:33 PST
Created attachment 224123 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 11 Samuel White 2014-02-13 16:43:11 PST
Created attachment 224129 [details]
Patch.

Updated log comment per review and fixed layout test expectations.
Comment 12 Samuel White 2014-02-14 09:51:04 PST
I'm going to let this one go in even though the mac WK2 bot looks flaky (I'll keep an eye on it and rollout if it is indeed an issue). Reason being, I'm seeing these same flaky issues in other patches that have already landed (watching the console). For example https://bugs.webkit.org/show_bug.cgi?id=128792 looks to have similar flaky test issues on mac-wk2. So, I suspect these are not related to this patch. Also, this patch doesn't make any changes to areas that are being flaky.
Comment 13 Samuel White 2014-02-14 12:25:36 PST
Comment on attachment 224129 [details]
Patch.

I'm going to rebase this one and run it through EWS again.
Comment 14 Samuel White 2014-02-14 14:14:16 PST
Created attachment 224253 [details]
Rebased patch.

Rebased because the commit bot was having trouble applying this one. Turns out it made no difference. Still, sending through EWS again to be double sure we aren't adding to the recent bout of test flakiness.
Comment 15 Samuel White 2014-02-14 14:15:42 PST
Same patch, just rebased. Chris, could you + this one again and I'll commit manually if everything looks good and the commit bot is still having issues. Thanks.
Comment 16 WebKit Commit Bot 2014-02-15 00:28:39 PST
Comment on attachment 224253 [details]
Rebased patch.

Clearing flags on attachment: 224253

Committed r164165: <http://trac.webkit.org/changeset/164165>
Comment 17 WebKit Commit Bot 2014-02-15 00:28:43 PST
All reviewed patches have been landed.  Closing bug.