Add the ability to limit element results to immediate container descendants only. This can be accomplished by supporting the following new keys and values: Key: AXImmediateDescendantsOnly (similar to AXVisibleOnly) Value: YES/NO Unless we suspect further descendant filtering needs will arise in the future. In which case we could start with: Key: AXSearchScope (similar to AXSearchText and AXSearchKey) Values: AXAllDescendants AXImmediateDescendants
<rdar://problem/16060264>
Created attachment 224090 [details] Patch for EWS. Ignore this patch, just looking for platform failures at this point.
Attachment 224090 [details] did not pass style-queue: ERROR: Source/WebCore/accessibility/AccessibilityObject.h:352: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 224091 [details] Patch for EWS. Fixing style and some build failures. Ignore.
Created attachment 224095 [details] Patch for review.
Comment on attachment 224095 [details] Patch for review. Attachment 224095 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6367487323013120 New failing tests: platform/mac/accessibility/search-predicate-immediate-descendants-only.html
Created attachment 224121 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 224095 [details] Patch for review. View in context: https://bugs.webkit.org/attachment.cgi?id=224095&action=review > Source/WebCore/ChangeLog:10 > + Added support for 'immediate descendant only' to existing predicate based searching. please add comment why we need this
Comment on attachment 224095 [details] Patch for review. Attachment 224095 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5257189958615040 New failing tests: platform/mac/accessibility/search-predicate-immediate-descendants-only.html
Created attachment 224123 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 224129 [details] Patch. Updated log comment per review and fixed layout test expectations.
I'm going to let this one go in even though the mac WK2 bot looks flaky (I'll keep an eye on it and rollout if it is indeed an issue). Reason being, I'm seeing these same flaky issues in other patches that have already landed (watching the console). For example https://bugs.webkit.org/show_bug.cgi?id=128792 looks to have similar flaky test issues on mac-wk2. So, I suspect these are not related to this patch. Also, this patch doesn't make any changes to areas that are being flaky.
Comment on attachment 224129 [details] Patch. I'm going to rebase this one and run it through EWS again.
Created attachment 224253 [details] Rebased patch. Rebased because the commit bot was having trouble applying this one. Turns out it made no difference. Still, sending through EWS again to be double sure we aren't adding to the recent bout of test flakiness.
Same patch, just rebased. Chris, could you + this one again and I'll commit manually if everything looks good and the commit bot is still having issues. Thanks.
Comment on attachment 224253 [details] Rebased patch. Clearing flags on attachment: 224253 Committed r164165: <http://trac.webkit.org/changeset/164165>
All reviewed patches have been landed. Closing bug.