In Tools/gtk/GNUmakefile.am, line 45: CC=$(CC) $(srcdir)/Tools/gtk/generate-gtkdoc This does not work if CC contains spaces. When I set CC to "clang -std=c11 -pedantic", I get the following error: CC=clang -std=c11 -pedantic ./Tools/gtk/generate-gtkdoc -std=c11: not found gmake[1]: *** [docs-build.stamp] Error 127 gmake[1]: *** Waiting for unfinished jobs.... We should change it to CC="$(CC)" so it will work even if CC contains spaces.
Created attachment 224059 [details] [GTK] Quote the CC and PKG_CONFIG variable
Created attachment 224317 [details] [GTK] Quote the CC and PKG_CONFIG variable (updated)
Attachment 224317 [details] did not pass style-queue: ERROR: Tools/ChangeLog:319: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Compiler flags should be placed into CFLAGS and CXXFLAGS environment variables.
Created attachment 224318 [details] [GTK] Quote the CC and PKG_CONFIG variable (updated again)
(In reply to comment #5) > Created an attachment (id=224318) [details] > [GTK] Quote the CC and PKG_CONFIG variable (updated again) In what case does an unquoted PKG_CONFIG break?
(In reply to comment #6) > (In reply to comment #5) > > Created an attachment (id=224318) [details] [details] > > [GTK] Quote the CC and PKG_CONFIG variable (updated again) > > In what case does an unquoted PKG_CONFIG break? It may not break. I found it when I found the unquoted CC, so I patched both CC and PKG_CONFIG.
(In reply to comment #7) > > In what case does an unquoted PKG_CONFIG break? > It may not break. I found it when I found the unquoted CC, so I > patched both CC and PKG_CONFIG. Well, the Makefile is full of unquoted variables (e.g. PYTHON in that very same line) :) Quoting PKG_CONFIG doesn't harm, but it probably doesn't fix anything either. I'd bet that if there was a case where PKG_CONFIG needed to be quoted something else would break. Anyway, quoting CC is fine. Altough, as Žan says, compiler flags shouldn't generally go there, setting CC to "icecc gcc", "ccache gcc" and friends is common practice.
Comment on attachment 224318 [details] [GTK] Quote the CC and PKG_CONFIG variable (updated again) I agree there's no point in changing PKG_CONFIG unless we're fixing an actual issue.
Comment on attachment 224318 [details] [GTK] Quote the CC and PKG_CONFIG variable (updated again) View in context: https://bugs.webkit.org/attachment.cgi?id=224318&action=review > Tools/ChangeLog:319 > * DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webCryptoMasterKeyForWebView:]): > Use the SPI to specify a key. > > +2014-02-13 Ting-Wei Lan <lantw44@gmail.com> This looks like it could break, btw, you want your ChangeLog entry at the top.
Created attachment 225444 [details] [GTK] Quote the CC variable
(In reply to comment #11) > Created an attachment (id=225444) [details] > [GTK] Quote the CC variable lgtm
Autotools build is gone now. Feel free to reopen if this is an issue with the CMake build.