Bug 128725 - [Mac] Add a WebKit1 SPI to get WebCrypto master key from a client
Summary: [Mac] Add a WebKit1 SPI to get WebCrypto master key from a client
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-12 22:13 PST by Alexey Proskuryakov
Modified: 2014-02-13 11:27 PST (History)
4 users (show)

See Also:


Attachments
proposed patch (4.12 KB, patch)
2014-02-12 22:18 PST, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-02-12 22:13:30 PST
WebKit1 variant of bug 128702.
Comment 1 Alexey Proskuryakov 2014-02-12 22:18:52 PST
Created attachment 224047 [details]
proposed patch

I'm not yet quite sure whether we need this, or if we should just have code in WebKit that puts the master key into Keychain.

Would like some feedback as to whether I did this correctly.
Comment 2 Alexey Proskuryakov 2014-02-12 23:34:21 PST
OK, I think that we need this, if only to make DumpRenderTree work regardless of whether keychain is locked.
Comment 3 WebKit Commit Bot 2014-02-13 11:27:27 PST
Comment on attachment 224047 [details]
proposed patch

Clearing flags on attachment: 224047

Committed r164042: <http://trac.webkit.org/changeset/164042>
Comment 4 WebKit Commit Bot 2014-02-13 11:27:29 PST
All reviewed patches have been landed.  Closing bug.