Bug 128719 - No need to save reservedZoneSize when dropping the JSLock
Summary: No need to save reservedZoneSize when dropping the JSLock
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
Depends on:
Reported: 2014-02-12 19:39 PST by Mark Lam
Modified: 2014-02-12 22:46 PST (History)
9 users (show)

See Also:

the patch. (13.79 KB, patch)
2014-02-12 19:49 PST, Mark Lam
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2014-02-12 19:39:08 PST
The reservedZoneSize does not change due to the VM being run on a different thread.  Hence, there is no need to save and restore its value.  Instead of calling updateReservedZoneSize() to update the stack limit, we now call updateStackPointerAtVMEntry() to do the job.  updateStackPointerAtVMEntry() will update the stackPointerAtVMEntry and delegate to updateStackLimit() to update the stack limit based on the new stackPointerAtVMEntry.
Comment 1 Mark Lam 2014-02-12 19:49:52 PST
Created attachment 224043 [details]
the patch.
Comment 2 Geoffrey Garen 2014-02-12 22:30:50 PST
Comment on attachment 224043 [details]
the patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=224043&action=review


> Source/JavaScriptCore/runtime/VM.cpp:735
> +void VM::updateStackPointerAtVMEntry(void* sp)

This should be named "setStackPointerAtVMEntry".
Comment 3 Mark Lam 2014-02-12 22:46:04 PST
Thanks for the review.  The patch has been updated and landed in r164018: <http://trac.webkit.org/r164018>.