Bug 128712 - Return immediately from DestroyPlugin IPC call
Summary: Return immediately from DestroyPlugin IPC call
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 176881
  Show dependency treegraph
 
Reported: 2014-02-12 17:54 PST by Antti Koivisto
Modified: 2018-01-19 16:42 PST (History)
2 users (show)

See Also:


Attachments
patch (3.96 KB, patch)
2014-02-12 18:07 PST, Antti Koivisto
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2014-02-12 17:54:21 PST
Don't unnecessarily wait for plugin termination.
Comment 1 Antti Koivisto 2014-02-12 18:07:36 PST
Created attachment 224037 [details]
patch
Comment 2 WebKit Commit Bot 2014-02-12 18:08:14 PST
Attachment 224037 [details] did not pass style-queue:


ERROR: Source/WebKit2/ChangeLog:15:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2014-02-12 21:45:48 PST
Comment on attachment 224037 [details]
patch

Sure, let's try this. If we see any fallout we can either:

1. Limit by plug-in type.
2. Only do this when we're certain that the plug-in isn't playing any audio, showing ui, etc.
Comment 4 Antti Koivisto 2014-02-12 21:59:55 PST
https://trac.webkit.org/r164015