Bug 128707 - Add relatedWebView property to WKWebViewConfiguration
Summary: Add relatedWebView property to WKWebViewConfiguration
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-12 17:24 PST by Anders Carlsson
Modified: 2014-02-12 17:49 PST (History)
1 user (show)

See Also:

Attachments
Patch (9.45 KB, patch)
2014-02-12 17:25 PST, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (9.48 KB, patch)
2014-02-12 17:29 PST, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (9.55 KB, patch)
2014-02-12 17:43 PST, Anders Carlsson 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-02-12 17:24:24 PST 
Add relatedWebView property to WKWebViewConfiguration
Comment 1 Anders Carlsson 2014-02-12 17:25:36 PST 
Created attachment 224029 [details]
Patch
Comment 2 Anders Carlsson 2014-02-12 17:29:10 PST 
Created attachment 224030 [details]
Patch
Comment 3 Anders Carlsson 2014-02-12 17:43:33 PST 
Created attachment 224031 [details]
Patch
Comment 4 WebKit Commit Bot 2014-02-12 17:45:08 PST 
Attachment 224031 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:34:  Missing spaces around =  [whitespace/operators] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 mitz 2014-02-12 17:46:35 PST 
Comment on attachment 224031 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224031&action=review

> Source/WebKit2/ChangeLog:14
> +        * UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm.

It’s weird to copy the header from a source file.
Comment 6 Anders Carlsson 2014-02-12 17:49:21 PST 
Committed r164004: <http://trac.webkit.org/changeset/164004>