RESOLVED FIXED 128704
Make code generation of the unoptimized pseudo classes separate 
https://bugs.webkit.org/show_bug.cgi?id=128704
Summary Make code generation of the unoptimized pseudo classes separate
Benjamin Poulain
Reported 2014-02-12 16:33:25 PST
Make code generation of the unoptimized pseudo classes separate
Attachments
Patch (8.53 KB, patch)
2014-02-12 16:37 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2014-02-12 16:37:01 PST
Created attachment 224027 [details] Patch
Andreas Kling
Comment 2 2014-02-13 20:09:23 PST
Comment on attachment 224027 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224027&action=review r=me > Source/WebCore/cssjit/SelectorCompiler.cpp:908 > + for (unsigned i = 0; i < fragment.unoptimizedPseudoClasses.size(); ++i) Range for?
Benjamin Poulain
Comment 3 2014-02-13 21:20:59 PST
(In reply to comment #2) > > Source/WebCore/cssjit/SelectorCompiler.cpp:908 > > + for (unsigned i = 0; i < fragment.unoptimizedPseudoClasses.size(); ++i) > > Range for? They generate bad code for going over arrays. I avoid them until clang is fixed :)
Benjamin Poulain
Comment 4 2014-02-14 12:42:01 PST
Comment on attachment 224027 [details] Patch Clearing flags on attachment: 224027 Committed r164118: <http://trac.webkit.org/changeset/164118>
Benjamin Poulain
Comment 5 2014-02-14 12:42:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.