Bug 128704 - Make code generation of the unoptimized pseudo classes separate
Summary: Make code generation of the unoptimized pseudo classes separate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-12 16:33 PST by Benjamin Poulain
Modified: 2014-02-14 12:42 PST (History)
1 user (show)

See Also:

Attachments
Patch (8.53 KB, patch)
2014-02-12 16:37 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-02-12 16:33:25 PST 
Make code generation of the unoptimized pseudo classes separate
Comment 1 Benjamin Poulain 2014-02-12 16:37:01 PST 
Created attachment 224027 [details]
Patch
Comment 2 Andreas Kling 2014-02-13 20:09:23 PST 
Comment on attachment 224027 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224027&action=review

r=me

> Source/WebCore/cssjit/SelectorCompiler.cpp:908
> +    for (unsigned i = 0; i < fragment.unoptimizedPseudoClasses.size(); ++i)

Range for?
Comment 3 Benjamin Poulain 2014-02-13 21:20:59 PST 
(In reply to comment #2)
> > Source/WebCore/cssjit/SelectorCompiler.cpp:908
> > +    for (unsigned i = 0; i < fragment.unoptimizedPseudoClasses.size(); ++i)
> 
> Range for?

They generate bad code for going over arrays. I avoid them until clang is fixed :)
Comment 4 Benjamin Poulain 2014-02-14 12:42:01 PST 
Comment on attachment 224027 [details]
Patch

Clearing flags on attachment: 224027

Committed r164118: <http://trac.webkit.org/changeset/164118>
Comment 5 Benjamin Poulain 2014-02-14 12:42:02 PST 
All reviewed patches have been landed.  Closing bug.