Bug 128701 - [EFL][WK1] Do not include libsoup header in the public headers
Summary: [EFL][WK1] Do not include libsoup header in the public headers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-12 16:00 PST by Ryuan Choi
Modified: 2014-02-13 05:20 PST (History)
7 users (show)

See Also:

Attachments
Patch (8.35 KB, patch)
2014-02-12 16:05 PST, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Patch (8.77 KB, patch)
2014-02-12 16:12 PST, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2014-02-12 16:00:22 PST 
Although ewebkit used libsoup internally, it's not good for EFL developers to use it.
Comment 1 Ryuan Choi 2014-02-12 16:05:05 PST 
Created attachment 224022 [details]
Patch
Comment 2 Ryuan Choi 2014-02-12 16:12:03 PST 
Created attachment 224023 [details]
Patch
Comment 3 Gyuyoung Kim 2014-02-12 16:37:09 PST 
Comment on attachment 224023 [details]
Patch

Basically, I agree not to open libsoup header in ewk header. However, it would be good to replace those APIs with new wrapper APIs together.
Comment 4 Ryuan Choi 2014-02-12 16:59:20 PST 
(In reply to comment #3)
> (From update of attachment 224023 [details])
> Basically, I agree not to open libsoup header in ewk header. However, it would be good to replace those APIs with new wrapper APIs together.

Basically, I think that it is wrong approach to expose session directly.

In my opinion, we'd better to expose proper APIs like ewk_view_proxy_uri_set instead of exposing setter/getter of session and letting application developers learn extra libraries.
Comment 5 Gyuyoung Kim 2014-02-12 17:08:37 PST 
(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 224023 [details] [details])
> > Basically, I agree not to open libsoup header in ewk header. However, it would be good to replace those APIs with new wrapper APIs together.
> 
> Basically, I think that it is wrong approach to expose session directly.
> 
> In my opinion, we'd better to expose proper APIs like ewk_view_proxy_uri_set instead of exposing setter/getter of session and letting application developers learn extra libraries.

Yes, I meant that it is nice to remove those APIs with new wrapper APIs together.
Comment 6 Gyuyoung Kim 2014-02-13 00:13:55 PST 
Comment on attachment 224023 [details]
Patch

As we talked, we believe that this APIs aren't being used now. So, let's remove it. r=me.
Comment 7 Ryuan Choi 2014-02-13 04:50:33 PST 
Comment on attachment 224023 [details]
Patch

Thanks.
Comment 8 WebKit Commit Bot 2014-02-13 05:20:21 PST 
Comment on attachment 224023 [details]
Patch

Clearing flags on attachment: 224023

Committed r164028: <http://trac.webkit.org/changeset/164028>
Comment 9 WebKit Commit Bot 2014-02-13 05:20:25 PST 
All reviewed patches have been landed.  Closing bug.