Bug 128687 - Web Inspector: Get InspectorIndexedDBAgent working
Summary: Web Inspector: Get InspectorIndexedDBAgent working
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-02-12 14:04 PST by Timothy Hatcher
Modified: 2014-02-13 13:33 PST (History)
8 users (show)

See Also:

Attachments
Patch (19.65 KB, patch)
2014-02-12 14:59 PST, Timothy Hatcher 		beidson: review+
beidson: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2014-02-12 14:04:49 PST 
Make InspectorIndexedDBAgent work again.
Comment 1 Radar WebKit Bug Importer 2014-02-12 14:05:40 PST 
<rdar://problem/16052081>
Comment 2 Timothy Hatcher 2014-02-12 14:59:35 PST 
Created attachment 224010 [details]
Patch
Comment 3 Brady Eidson 2014-02-12 15:06:28 PST 
Comment on attachment 224010 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224010&action=review

> Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:62
> +typedef HashMap<String, HashSet<String>> IDBRecentDatabaseNameMap;
> +
> +static IDBRecentDatabaseNameMap& sharedRecentDatabaseNameMap()

There's been a recent growing backlash against typedefs for maps like these.  I know there's some in the IDB code already.  Please don't add this new one  :)

> Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:129
> +    ASSERT(!securityOriginIdentifier.isNull());

s/isNull/isEmpty/
Comment 4 Joseph Pecoraro 2014-02-12 15:25:10 PST 
Comment on attachment 224010 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224010&action=review

> Source/WebCore/ChangeLog:18
> +        Make DOMStringList.h private some WebKit2 can use it.

Typo: "some" => "so"

> Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:100
> +        callbacks->onError(IDBDatabaseError::create(IDBDatabaseException::InvalidAccessError, "Document is not allowed to use Indexed Databases"));

Nit: You could use ASCIILiteral for the Error string.
Comment 5 Timothy Hatcher 2014-02-13 13:33:38 PST 
http://trac.webkit.org/changeset/164051