Bug 128687 – Web Inspector: Get InspectorIndexedDBAgent working

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Timothy Hatcher]

Make InspectorIndexedDBAgent work again.

[Radar WebKit Bug Importer]

<rdar://problem/16052081>

[Timothy Hatcher]

Created attachment 224010 [details]
Patch

[Brady Eidson]

Comment on attachment 224010 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224010&action=review

> Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:62
> +typedef HashMap<String, HashSet<String>> IDBRecentDatabaseNameMap;
> +
> +static IDBRecentDatabaseNameMap& sharedRecentDatabaseNameMap()

There's been a recent growing backlash against typedefs for maps like these.  I know there's some in the IDB code already.  Please don't add this new one  :)

> Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:129
> +    ASSERT(!securityOriginIdentifier.isNull());

s/isNull/isEmpty/

[Joseph Pecoraro]

Comment on attachment 224010 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224010&action=review

> Source/WebCore/ChangeLog:18
> +        Make DOMStringList.h private some WebKit2 can use it.

Typo: "some" => "so"

> Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:100
> +        callbacks->onError(IDBDatabaseError::create(IDBDatabaseException::InvalidAccessError, "Document is not allowed to use Indexed Databases"));

Nit: You could use ASCIILiteral for the Error string.

[Timothy Hatcher]

http://trac.webkit.org/changeset/164051