Bug 128677 - Clean up PageThrottler interface
Summary: Clean up PageThrottler interface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-12 11:16 PST by Gavin Barraclough
Modified: 2014-02-12 13:51 PST (History)
9 users (show)

See Also:

Attachments
Fix (18.61 KB, patch)
2014-02-12 11:53 PST, Gavin Barraclough 		benjamin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2014-02-12 11:16:11 PST 
Currently, responsibility for throttling DOM timers & suspending animations is split between the Page & the PageThrottler. Clarify by making Page responsible for suspending animations (PageThrottler is now purely related to aspects of timer throttling), and move all timer throttling policy to the PageThrottler, with a single function on Page to enable (Page::setTimerThrottlingEnabled).

Also, transmit the full ViewState to the PageThrottler (not just the IsVisuallyIdle flag), and distinguish between media & page-load activity.
Comment 1 Gavin Barraclough 2014-02-12 11:53:20 PST 
Created attachment 223989 [details]
Fix
Comment 2 WebKit Commit Bot 2014-02-12 11:55:52 PST 
Attachment 223989 [details] did not pass style-queue:


ERROR: Source/WebCore/page/PageThrottler.h:46:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gavin Barraclough 2014-02-12 13:51:33 PST 
Transmitting file data ..........
Committed revision 163983.