Bug 128676 - Add a mac-wk1 platform directory and TestExpectations file
Summary: Add a mac-wk1 platform directory and TestExpectations file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-12 11:11 PST by Brady Eidson
Modified: 2014-02-12 11:25 PST (History)
3 users (show)

See Also:


Attachments
Patch v1 - Add mac-wk1 search path and seed its TestExpectations with skipping indexeddb (4.77 KB, patch)
2014-02-12 11:14 PST, Brady Eidson
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-02-12 11:11:36 PST
Add a mac-wk1 platform directory and TestExpectations file

With some WK2-only features on Mac (like IndexedDB), it doesn't make sense to have mac-wk2 inherit from mac-wk1 expectations...  so we need mac-wk1 expectations to be separate.
Comment 1 Brady Eidson 2014-02-12 11:14:30 PST
Created attachment 223984 [details]
Patch v1 - Add mac-wk1 search path and seed its TestExpectations with skipping indexeddb
Comment 2 Alexey Proskuryakov 2014-02-12 11:19:13 PST
Comment on attachment 223984 [details]
Patch v1 - Add mac-wk1 search path and seed its TestExpectations with skipping indexeddb

It would be helpful to go over all those tests that are disabled in platform/mac/TestExpectations, and re-enabled in platform/mac-wk2/TestExpectations
Comment 3 Brady Eidson 2014-02-12 11:23:30 PST
(In reply to comment #2)
> (From update of attachment 223984 [details])
> It would be helpful to go over all those tests that are disabled in platform/mac/TestExpectations, and re-enabled in platform/mac-wk2/TestExpectations

Agreed.  Mechanical task as a followup!
Comment 4 Brady Eidson 2014-02-12 11:25:25 PST
http://trac.webkit.org/changeset/163968